Phpinspectionsea: Couldn't detect NPE when calling static method

[Koc]

expected warning about NPE when calling convertDateTimeToDateKey

[rentalhost]

Okay, I could reproduce it.

<?php

declare(strict_types = 1);

class Example
{
    public function checkIssue(): void
    {
        // Don't warn. Fail. Both should be warned.
        $this->expectDateTime($this->returnNullable());
        $this->expectDateTime(null);

        // Warn okay (EA inspection).
        $dateTime = $this->returnNullable();
        $this->expectDateTime($dateTime);

        // Warn okay (PS inspection).
        $this->expectDateTime(new stdClass);
    }

    public function expectDateTime(DateTime $dateTime): void
    {
    }

    public function returnNullable(): ?DateTime
    {
        return new DateTime;
    }
}

[funivan]

@rentalhost I think this can go to the Ultimate ;)

[kalessil]

@Koc : any chance that you would like to migrate onto https://plugins.jetbrains.com/plugin/10215-php-inspections-ea-ultimate- (commercial and enhanced version of the plugin) ? I'm asking as I need to make a decision which of plugins getting this enhancement.

[Koc]

not now, but you can move to commercical version, no problem

[kalessil]

Will it be fair in your opinion?

[Koc]

100%. A agree that this plugin prevents errors in some cases and make my work much productive. Just for now I have some financing problems and maybe will buy plugin next year.

[kalessil]

Thank you!

[Koc]

@kalessil can you create comparation table for free/paid version and include link on it in plugin pages?

[kalessil]

Will do (next days if not get ill completely)

[kalessil]

Implemented, the comparison list to be published in early January.

[kalessil]

@Koc : here we go with Ultimate-plugin details https://kalessil.github.io/page-blog-post-about-ea-ultimate.html