Phpinspectionsea: This condition is duplicated in another if/elseif branch

[funivan]

$file = 'text_new.html';
if (!is_file($file)) {
  $file = 'text_old.html';
  if (!is_file($file)) { // <-- error
    $file = 'text_fallback.html';
  }
}

Hello. I refactor some legacy code. And here is what I find.
When we check variable, then modify it, and then check again - we get false-positive.

[kalessil]

Oh noeeeeesssss, my beloved case =)
May I ask you to cross-link similar issues here, so I would know which functions to handle in a special way please?

[funivan]

@kalessil sure. If I find some similar I will post it.

[kalessil]

Similar issues: #381, #339, #289.

[AMartinNo1]

I can confirm this. This is part of my legacy code in case it helps developing a solution:

<?php
$sVariante = $aLine[$this->getIndexOfColumnInArticlesCsv('attr_artikel_var_laufzeit')];
 if ($sVariante != null && strlen(trim($sVariante)) > 0)
{
    // ...
}
else
{
    $sVariante = $aLine[$this->getIndexOfColumnInArticlesCsv('attr_artikel_var_user')];
    if ($sVariante != null && strlen(trim($sVariante)) > 0)
    {
        // ...
    }
}

[kalessil]

Hopefully, I'll deal with the issue in this release.

[kalessil]

Fixed!