Phpinspectionsea: New pattern: one-time use variable [aggressive behaviour, also fors' inits definition]

[kalessil]

$variable = <expression>;
while ($variable) { /* but not $variable comparison expression */
    ...
    $variable = <same expression>;
}

replace with

while ($variable = <expression>) {
    ...
}

[bram123]

This does go against "PHP | Probable bugs | Assignment in condition".
Possible to active this pattern based on that inspection's setting?

[kalessil]

Nope, we'll need just to generate suppression then with our QF.

[davidmpaz]

What does it means:

Nope, we'll need just to generate suppression then with our QF.

How will it works?

Point aside. My personal experience is that I found my self often breaking apart very long (spaghetti like) conditions in those while, even if I repeat them inside the loop, just for the sake of readability.

From the point of view of performance I don't know whether we gain something though.

I would use it only for simple conditions, fitting in one line of code (~80 chars) for example.

[bestform]

I don't think it is a good idea to use an assignment in this condition. Depending on the expression, it will make the code harder to read. And every developer who is used to avoid assignments in condition will inevitably stumble upon this code and question it.

[kalessil]

@davidmpaz

/* @noinspection <Assignment-in-condition-inspection> */
while ($variable = <expression>) {
    ...
}

The inspection would be very questionable, Twitter poll is 50-50 pro and cons as well.
We gaining no performance, but dropping 2 lines of code and introducing assignment in a condition.

[kalessil]

@bestform: I agree and tempted at the same time. If my Twitter poll keeps being biased, we'll probably skip this.

[davidmpaz]

Ok got it. Voted already :)

[Ocramius]

Looks good to me 👍

[drealecs]

The only bad thing is when the variable has other assignments in the while loop.

[kalessil]

Right @drealecs, this noted down now ^_^

[rentalhost]

I prefer that it be done inside the own looping (maybe cost performance, but it more clear).

while (true) {
    $variable = <expression>;

    if (!$variable) {
        break;
    }
}

[kalessil]

@rentalhost : this one is super-controversial =)

[kalessil]

So, we collected pretty much feedback and it's pretty controversial =)
We'll introduce a new setting: "Aggressive inlining (while, foreach)" disabled by default.

[rentalhost]

I know, but it avoid the _assignment-as-expression_ that sounds bad for me, and turn more hard identify a cause of a problem, once that you could confuses about = and ==.

[kalessil]

@rentalhost, fully understandable =)

[kalessil]

Marking 2.3.10 to review twitter poll results.

[stale[bot]]

Bebo beep, the StaleBot is here. For one year nothing have happened here. It would be great if someone looked into details here within next 21 days when I'll close it.