Phpinspectionsea: SecurityAdvisoriesInspector: Package names are case insensitive

[bcremer]

Package names in composer.json are case insensitive. The new developmentPackages inspection is unable to detect packages which are not written in the exact casing of the list used here: https://github.com/kalessil/phpinspectionsea/blob/bf44082382db16e6bdad761c2621e35fa24b8dd9/src/main/java/com/kalessil/phpStorm/phpInspectionsEA/inspectors/security/SecurityAdvisoriesInspector.java#L33

Example composer.json:

{
  "require": {
    "phpunit/PHPUnit": "^5.4"
  }
}

[Ocramius]

This should probably be added to composer validate

[bcremer]

Just to be clear, composer itself ignores package name casing during install. The package name get's normalized to it's canonical version in the composer.lock however.

[Ocramius]

Well aware of it, but a lot of tooling might not be doing that, so it's probably a different inspection about case sensitivity overall

[kalessil]

Good catch =) I'll add normalizing for package names.

[kalessil]

@Ocramius: any examples when we would need package name case inspection?

[Ocramius]

That's mostly because package names are assumed to be lowercase: same issue
that happened here may happen in other dependency analysis tools.

On 28 Jun 2017 10:47 PM, "Vladimir Reznichenko" [e-mail]
wrote:

@Ocramius https://github.com/ocramius: any examples when we would need
package name case inspection?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kalessil/phpinspectionsea/issues/367#issuecomment-311785028,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakEptTBYPToC3L4BHAjLol-z9FheKks5sIrvggaJpZM4OHg2C
.

[kalessil]

Well, then I'd rather skip the case-sensitivity check - don't see benefits for our community.