Phpinspectionsea: Unused constructor dependencies: static context must be inspected

[funivan]

Find a bug.

  class UserInfo {

    private $name;

    public function __construct(string $name) {
      $this->name = $name; // Get error here
    }

    public static function getPrinter() {
      return function (UserInfo $userInfo) {
        return $userInfo->name;  // But property is used here.
      };
    }

  }

  $user = new UserInfo('funivan');
  $printer = UserInfo::getPrinter();
  echo $printer($user);

If we change public static function getPrinter() to public function getPrinter() then inspection works fine )

[kalessil]

That's a very confusing design: the return (string)$userInfo should be used here (with __toString implementation of course).

I don't do this often, but I think we should leave as it is now but reflect this case and solution in docs.

[funivan]

This is simple example. Here is real use case from symfony:
https://github.com/symfony/symfony/blob/7e766dae4a88be16dd5d7f4927deb032e0573a08/src/Symfony/Component/Console/Helper/ProgressIndicator.php#L244

[kalessil]

Makes no difference, except private static function initPlaceholderFormatters() is private.
I need to think, handling this will complicate the inspector a lot...

[funivan]

@kalessil agree, this is very specific case. The most simple way to add documentation)

[rentalhost]

Why when you set it as non-static it works fine? Maybe some if() is causing this issue. Static should be allowed to work with cases like that.

[kalessil]

@rentalhost : that's a trick (argh!!!) for accessing non-public properties:

• the lambdas created inside the class, so they have access to all internals (incl. all private things);
• the lambdas dispatched to an outer consumer, which calls the lambda without side-effects;

It's VERY dirty hacking, alternative is to use decorators

[rentalhost]

Wow, it's very hard to understand what this code does. After rerereading that I finally get. But still is hard, maybe because of this strange pattern (or antipattern, I don't know now, I am confused haha).

In all case, I guess that you could make it works on inspection.
PHP allows this kind of thing, after all.

In this case, I guess that only need get all anonymous functions on class that make references to own class (_write on line 111_), then treats like a common class method and check the property references. I guess that it should be done like (warning: pseudo-code):

Collections.addAll(methodsToCheck, constructor.getContainingClass().getOwnMethods());

for (PhpClass trait : constructor.getContainingClass().getTraits()) {
    Collections.addAll(methodsToCheck, trait.getOwnMethods());
}
// ^^^ current code. ^^^

// Check all collected methods to find anonymous functions.
for (Method methodToCheck: methodsToCheck) {
    Function[] anonymousFunctions = PSAPI.findAnonymousFunctions(methodToCheck);
    if (anonymousFunction.size() > 0) {
        // We found something.
        // Check if it refers to own class.
        for (Function anonymousFunction: anonymousFunctions) {
            Parameter[] functionParameters = anonymousFunction.getParameters();
            for (Parameter functionParameter = functionParameters) {
                if (functionParameter.getType() === clazz) {
                    // Once we found something, we can jump to next anonymous function iteration.
                    // Is possible that we have other references on it.
                    methodsToCheck.add(anonymousFunction);
                    continue 2;
                }
            }
        }
    }
}

// vvv current code. vvv

[kalessil]

The approach from @rentalhost should be sufficient, I'll give it a try.

[kalessil]

Fixed, I had only to remove static method checks - main logic is not changed.