Phpinsights: [internal] Release 1.7.0 ?

Created on 20 Jun 2019  ยท  11Comments  ยท  Source: nunomaduro/phpinsights

Hey guys,

Maybe it's time for a new release ?

Changelog

To summarize, we have:

New Features:

  • [x] Two new Insights about Composer (ComposerMustBeValid and ComposerLockMustBeFresh) (PR #169)
  • [x] CyclomaticComplexityIsHigh insight is now configurable (PR #190)
  • [x] Add support for ignoring a file on specific sniff (PR #182)

Fix:

  • [x] Disable ForbiddenSecurityInsight is now possible (PR #175 PR #187)
  • [x] Fix duplicate unused parameters sniffs (PR #179)

Improvments:

  • [x] reduce dist size (PR #189)
  • [x] Docs contains list of insight, how to configure, and testimonial pages

WDYT ?

Most helpful comment

@nunomaduro I take a plane in one hour, so I let you do the release :sweat_smile:

All 11 comments

@nunomaduro Can you also recheck #166 before the next release ? To be sure we'll have a new docker image ?

I think it is time. @nunomaduro also wrote in #190 that he will release tonight.

Yes I saw that just after publishing this issue :sweat_smile:

Nice of you to create the changelog list to make it easier for releasing ๐ŸŽ‰

Let's see if we can get the twitter handles also, to make it even easier :)

@tvbeek, @iKrisnaw, @jibbarth, @OliverNybroe, @enunomaduro, FFDevelopment

@FFDevelopment if you have twitter, we would like the tag you on the next release. I cannot find your handle on twitter ๐Ÿ‘ No twitter.

Can we try to remove the dependency composer/composer before having this release ready? Here is the list of extra dependencies installed in a laravel project on this new version:

  - Installing composer/spdx-licenses (1.5.1): Loading from cache
  - Installing justinrainbow/json-schema (5.2.8): Loading from cache
  - Installing seld/phar-utils (1.0.1): Loading from cache
  - Installing seld/jsonlint (1.7.1): Loading from cache
  - Installing composer/ca-bundle (1.1.4): Loading from cache
  - Installing composer/composer (1.8.6): Downloading (100%)         
  - Removing nunomaduro/phpinsights (v1.6.0)
  - Installing nunomaduro/phpinsights (dev-master 3fdee8d): Downloading (100%)  

:thinking: The dependency for composer/composer was introduced in #169 with new Composer Insights to use command from composer.
If we remove it, theses insights will not work anymore ?

@Jibbarth Alright, let's keep this. Eventually, if someone complains we work in away of making this optional or even refactor it to remove those dependencies.

@Jibbarth Do you wanna do the release yourself? ๐Ÿ’‡๐Ÿปโ€โ™‚๏ธ Don't forget to post here the tweet so I can retweet it.

@olivernybroe It's missing my twitter handler on that ๐Ÿ’ƒ

@nunomaduro Didn't include yours because I thought you were doing the release ;) Sorry! :*

@nunomaduro I take a plane in one hour, so I let you do the release :sweat_smile:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

nunomaduro picture nunomaduro  ยท  5Comments

danilocorrea87 picture danilocorrea87  ยท  4Comments

dmitryuk picture dmitryuk  ยท  5Comments

Naxon picture Naxon  ยท  4Comments

davi5e picture davi5e  ยท  4Comments