Phpinsights: [Laravel Preset] Should Insights ignore useless override?

Created on 20 May 2019  Â·  3Comments  Â·  Source: nunomaduro/phpinsights

| Q | A
| ---------------- | -----
| Bug report? | no
| Feature request? | yes
| Library version | latest

• [Code] Useless overriding method:
  app/Exceptions/Handler.php:42: Possible useless method overriding detected
  app/Exceptions/Handler.php:54: Possible useless method overriding detected
  app/Providers/EventServiceProvider.php:26: Possible useless method overriding detected

Laravel skeleton comes with some 'useless' overrides to show where developers may choose to do things related to Exception Handler or Event configuration. I'd prefer to keep these parts of the skeleton untouched instead of removing them to satisfy the tool, thus keeping standard Laravel skeleton.

enhancement

Most helpful comment

It's in our plans to add something to ignore this on the future.

All 3 comments

I have mixed feelings on this. Let's keep this open.

Personally, i like to keep the methods, even if not used, but yeah, the warning is a bit annoying.

perhaps some optional way to disable it, only for the default laravel files?

It's in our plans to add something to ignore this on the future.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

fluffycondor picture fluffycondor  Â·  3Comments

nunomaduro picture nunomaduro  Â·  5Comments

nunomaduro picture nunomaduro  Â·  5Comments

Gummibeer picture Gummibeer  Â·  4Comments

ijpatricio picture ijpatricio  Â·  3Comments