Php-graph-sdk: Dropping the `-v4` suffix from the repo & Packagist

[SammyK]

Let's finally knock out the conversation that started way back in #411 and drop the -v4 from this repo name and Packagist. It's causing a lot of confusion with devs learning the Facebook PHP SDK for the first time so it'll be good to finally fix this. :)

We'll need help from Vivek on this one, but step one would be rename the repo in GitHub then point Packagist to the new repo name. Vivek: Here's the direct edit link on Packagist.

Then we can discuss renaming the package on Packagist to facebook/sdk. I believe this is done by abandoning facebook/php-sdk-v4 and updating the name in composer.json to facebook/sdk and resubmitting. @yguedidi @stof Is that right?

[yguedidi]

Looks good to me :)

[yguedidi]

But I'd suggest facebook/graph-sdk for packagist package name haha

[SammyK]

But I'd suggest facebook/graph-sdk for packagist package name haha

Yeah, that's a good idea since that would disambiguate it from the ads SDK and any other PHP SDK's @ Facebook.

Ping @viv001 :)

[viv001]

Sounds good guys! I will have a look on Monday and follow up on this thread :)
One thought though - Is there a reason we want to drop "php" from the package name? Like why not facebook/php-graph-sdk (I'd also consider facebook/php-graph-api-sdk) ?

[SammyK]

Sweet - thanks @viv001!

Is there a reason we want to drop "php" from the package name?

It's just to remove some redundancy. Packagist only hosts php packages so there's no need for the prefix. :)

[stof]

@SammyK the process of updating is indeed right.
And +1 for removing the php redundancy in the composer package name (the github repo can of course keep it as there are other repositories)

[SammyK]

Thanks @stof! :)

Perhaps we could rename the repo to match the name on Packagist but with a php- prefix.

Packagist: facebook/graph-sdk
GitHub: facebook/php-graph-sdk

[stof]

Looks good to me

[viv001]

Update: Changed the github repo name
Waiting on previous owner of the corresponding packagist to grant me admin access to the package. Shall change the url and the name on it once I have the privileges.

[SammyK]

Yay! Thanks @viv001! :)

[viv001]

Update 2: Updated composer.json and switched packagist to use the new package. Also set up corresponding github service hook for auto-update.
@SammyK, @yguedidi : Can you confirm everything is as expected and close this? :)

[SammyK]

Yes! Works perfectly on my tests! Once @yguedidi confirms, we can close this one out. :)

@viv001 One more quick suggestion. The the old facebook/php-sdk suggests using the facebook/php-sdk-v4 package.

Can we update this one on Packagist to point to the new package as well? :)

[viv001]

Done :)

[yguedidi]

Looks good! We finally remove it!! :)

[SammyK]

Thanks for everyone's help on this! ❤️