Php-graph-sdk: Example snippets show PHP SDK v4.0 API

[SammyK]

The Graph API reference docs show the code snippets for v4.0 even though there's a comment above it saying that it's v5.

Not sure how to send a PR for that one. :)

[stefanledin]

I've been struggling with this for a couple of days now. Copy/paste from the documentation results in errors about the execute() method which doesn't exist in the request object.
I had to dive into the source in order to hack together a working solution. The documentation is just confusing right now :/

[SammyK]

Hey @gfosco! How do you want to handle documentation changes going forward? :)

[SpaHost]

More than 1 year... and still happening

[SammyK]

Hey @viv001! What would be involved with updating the snippets in the documentation? Is there anything I can do to help with this one? :)

[viv001]

Hey @SammyK, we are thinking of moving away from Facebook's external documentation for this SDK. We should have the documentation on GitHub and a link to it on Facebook's documentation page. Do you think that's feasible?

[SammyK]

Hey @viv001! Just want to make sure I understand correctly, we want to move the docs back to Facebook doc website? Or we want to point the Facebook docs pages to the SDK?

[viv001]

We want to point the Facebook docs to the SDK. So, any doc changes can be made on github without having to change Facebook's docs.

[SammyK]

Sounds good! Is there anything I can do to help with this?

[viv001]

I think we just have to make changes on Facebook's end since the up-to-date docs are already on Github. I shall talk to our team here and keep you updated through this task :)

[yguedidi]

@viv001 any news on this one? :)

[viv001]

This is fixed https://developers.facebook.com/docs/php/gettingstarted :)

[SammyK]

Thanks @viv001! It's still showing the v4 syntax in the code snippets at the top even though the comment says it's for v5.

[yguedidi]

ping @viv001 :)

[viv001]

Hi folks, sorry I wasn't getting notified about these pings for some reason - We are now working to get this removed from our page completely and just point to the github repo docs. I will loop back on this as soon as I have an update.

[yguedidi]

@viv001 Thank you!! Is it possible for @SammyK and I to have full access on this repo as we are the maintainers since years now? :)

[viv001]

@yguedidi For sure! I will just get the final approvals from our internal Open Source team and we should be good to go.
On a related note, I am not able to access settings for this repo anymore ; it doesn't seem like I am the admin - is there any way to confirm this?

[SammyK]

Thanks @viv001! Yeah, I'm not able to assign issues to you so I'm guessing you're not admin of the repo anymore?

[gfosco]

I added @viv001 back as an Admin on this repo.

[yguedidi]

Thanks @viv001 and @gfosco !!! :)

[SammyK]

This finally got updated! Yay! Thanks! :D