Php-ffmpeg: Move from phpunit 4.8 to 6.3 and from php 5.4 to 7.1

[jens1o]

| Q | A
| -------------- | ---
| Bug? | Perhaps
| New Feature? | Yes

Actual Behavior

We still use phpunit 4.8, which is deprecated... 😭

Expected Behavior

Use something that is ready for php 7.2

Setting PHP 7.1 as a minimum value should resolve this.

--

• [ ] Set declare(strict_types=1); in every file and fix any type-converting struggles.
• [ ] Use scalar type hints, null type hints and return type values(even void) in any classes.
• [ ] Check whether we have any workarounds for older php versions
  
  
  
  • [ ] Remove them if they aren't necessary anymore.
  
  
• [ ] Convert any array(...) to [...]

[jens1o]

Oh.. 6.3 is just for PHP 7.x :(

maybe PHPUnit 5.7, which would mean that we drop support for anything less than php 5.6.

Thoughts?

[huglester]

I think most of people are already on 7.0, 5.6, 7.1
so upping the requirements should not be the problem.

[jens1o]

Okay, nice to hear that. But #419 confused me a bit. Thanks for the response!

[huglester]

just make sure you tag last version of 5.3 or so... then just jump to 7.0 for example - with version 1.0

symfony newest LTS version is moving to 7.1, laravel is on 7.0+
5.6 is almost eol already..

You never will make everyone happy :)
but moving to newer version will force you to use newer, more feature rich dependencies and it will make this project easier to be required in probably newer projects

but as I see you are already using 7.0 syntax, no? if so - just close this :)

[jens1o]

PHP 7.0 will be EOL before to PHP 5.6. Okay, let's jump to PHP 7.1 directly(I'm sooo happy to do this)

[griffins]

7.2

[jens1o]

@griffins What do you want to say with this?

The change is actually done, and it works great :)

[acodinguy]

php 5.6.x or php 5.5.x

[jens1o]

@acodinguy I'm sorry? Could you elaborate on this?

[jens1o]

Updated the issue description with tasks.