Php-cs-fixer: Allow Symfony 5

Created on 17 Nov 2019  路  11Comments  路  Source: FriendsOfPHP/PHP-CS-Fixer

Symfony 5 is just around the corner, but I can't use it in any of my projects since I also require this lib.

kinenhancement

Most helpful comment

A tag on 2.15 was created (2.15.4) but we're still missing a tag on 2.16, and Composer is preferring it, downgrading Symfony as a result. Can we please have a 2.16.1 too?

All 11 comments

Please see #4608.

Note: if you only use PHP CS Fixer as a tool, you can install it in a dedicated directory (e.g. tools/php-cs-fixer/composer.json) so it doesn't conflict with the actual dependencies of your project.

@juliendufresne that's a suitable solutions for projects/applications, not for libraries/bundles

not for libraries/bundles

why not?

BTW wrong Julien 馃槂

Sorry for the wrong reference @julienfalque
@kubawerlos because a library has probably a wider audience and wants to ensure every user getting all relevant tools to keep quality. Moreover, it can use this tool in some automated checks, so keeping it the dev requirement can be easier than install an external package

it can use this tool in some automated checks, so keeping it the dev requirement can be easier than install an external package

I still cannot see what's the problem with Julien's solution - "dev requirement" is simply what we got used to for years.

Check here - nothing in require-dev and still 2 commands (composer update and composer verify) are all that you need to set it up and run all checks.

Closing as #4608 was merged.

@julienfalque would you also create a new tag so it's not necessary to install dev version?

A tag on 2.15 was created (2.15.4) but we're still missing a tag on 2.16, and Composer is preferring it, downgrading Symfony as a result. Can we please have a 2.16.1 too?

it was released to 2.15.5 and 2.16.1 on same time. it was never met to go to 2.15.4.
looks like typo in your msg.

Nope, I mistakenly thought that 2.15.4 included #4608, that's why I was confused. Thanks!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

OskarStark picture OskarStark  路  3Comments

grachevko picture grachevko  路  3Comments

sennewood picture sennewood  路  3Comments

Bilge picture Bilge  路  3Comments

datenmeister picture datenmeister  路  3Comments