Php-cs-fixer: [Proposal] Array Un-Align Fixer
Does the reverse of our array align fixer, and makes sure array elements are not aligned up.
I'd be happy to write this for the contrib level to hopefully go into 1.5.
GrahamCampbell
All 21 comments
I won't be using it, but yeah, why not. If anyone will then it is a nice to have it !
keradus
on 16 Dec 2014
Yeh, there's been some talk in the symfony community about applying such a standard to symfony, nothing concrete yet though.
I'll get this done shortly - if not today, then this week.
GrahamCampbell
on 16 Dec 2014
OK.
keradus
on 16 Dec 2014
Can we reopen this, i know some projects that would like this ;)
2014-12-16 22:50 GMT+01:00 Dariusz Rumiński [email protected]:
OK.
—
Reply to this email directly or view it on GitHub
https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/882#issuecomment-67238747
.
ceeram
on 17 Dec 2014
I didn't close it, it was @GrahamCampbell
From what I understood the fixer will be proposed by @GrahamCampbell , the idea wasn't rejected ;)
keradus
on 17 Dec 2014
Yeh. It's going to be the very next fixer for me to write.
GrahamCampbell
on 17 Dec 2014
Cool, having an open ticket for that is nice, both for contributors as
users.
2014-12-17 1:14 GMT+01:00 Graham Campbell [email protected]:
Yeh. It's going to be the very next fixer for me to write.
—
Reply to this email directly or view it on GitHub
https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/882#issuecomment-67257263
.
ceeram
on 17 Dec 2014
Sure.
GrahamCampbell
on 17 Dec 2014
As of https://github.com/symfony/symfony/commit/51312d31cc0ab034c6a780d02b6b31f51d7136ec, this fixer can now by symfony level.
GrahamCampbell
on 17 Dec 2014
:+1: yes please :yum:
sstok
on 23 Dec 2014
:+1:
@GrahamCampbell i have tried with symfony level but nothing happen.
ghost
on 14 Apr 2015
Nothing happen because this is only _proposal_ of fixer at Symfony level.
keradus
on 14 Apr 2015
If nobody does this by July/August, I'll take it on. :)
GrahamCampbell
on 14 Apr 2015
nearly 1 year after the issue created, it's too long @GrahamCampbell , could you start it now ?
ghost
on 15 Apr 2015
It would be great to have it done indeed, but please remember @ptcong, everyone of us spend his free time to work on this project, and we simply need to use some kind of prioritization.
If you want that fixer done please simply consider helping creating it (guide).
keradus
on 15 Apr 2015
@keradus ya, i know, but i mean, after 1 years, still have nobody take it then @GrahamCampbell should take it nearly if he have free time, don't need to wait others take it.
ghost
on 15 Apr 2015
@ptcong No, I'm telling you I will do it then. I'm not bringing it forward. If you want to write it first, then that's fine by me. I just won't be doing it any earlier.
GrahamCampbell
on 15 Apr 2015
Implemented in #1167 and #1168
keradus
on 22 Apr 2015
Closing due to merge of both PRs
keradus
on 22 Apr 2015
Guys, just wondering, what is the reason of implementing these fixers and why alignment is not correct?
pliashkou
on 15 May 2016
why alignment is not correct?
It makes more sense to not align to reduce diff sizes and prevent merge conflicts.
GrahamCampbell
on 15 May 2016
Related issues
Bilge
·
3Comments
ndench
·
3Comments
kcloze
·
3Comments
OskarStark
·
3Comments
teohhanhui
·
3Comments
Most helpful comment
It makes more sense to not align to reduce diff sizes and prevent merge conflicts.