Php-cs-fixer: All config options should follow the same casing rules

Created on 23 Feb 2018  路  6Comments  路  Source: FriendsOfPHP/PHP-CS-Fixer

Most options seems to follow snake_case, but some like header_comment have commentType. Would be good to normalise these

kinBC break kincleanup kinrefactoring topidocumentation

Most helpful comment

So in terms of branches:

  • The AutoReview targets 2.2
  • The new options that suppress the old options targets 2.2
  • The deprecation of non snake_case options targets master
  • The removal of deprecated options targets 3.0

Is this correct?

All 6 comments

Good point.

Things to do:

  • create an AutoReview test that check if all options are snake_case,
  • for those which not, make new option that suppresses old option (comment_type over commentType), deprecate old option and make it an exception to new AutoReview check
  • make dedicated PR for 3.0 line to remove deprecated options

@ntzm , would you like to dive into it?

I would love to!

So in terms of branches:

  • The AutoReview targets 2.2
  • The new options that suppress the old options targets 2.2
  • The deprecation of non snake_case options targets master
  • The removal of deprecated options targets 3.0

Is this correct?

@SpacePossum is there a roadmap when the 3.0 version will be released?

Hi,
I missed the last checking with the maintainers, but AFAIK there is no target date besides "this year" (I hope we make that one : ) ).

Was this page helpful?
0 / 5 - 0 ratings

Related issues

sennewood picture sennewood  路  3Comments

grachevko picture grachevko  路  3Comments

teohhanhui picture teohhanhui  路  3Comments

UksusoFF picture UksusoFF  路  3Comments

carusogabriel picture carusogabriel  路  3Comments