Php-cs-fixer: [RFC] Use PHPUnit dedicated method
Recently, I made several PRs in Symfony refactoring some tests, and I believe we can automatize this with this library.
I'd like to discuss with the core team what is possible to do with PHP Tokens (also what should I study to create this Fixer).
Related to https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3342#issuecomment-354742676.
carusogabriel
All 8 comments
Sounds great :)
Maybe it would be nice to start listing the changes so these can be discussed
SpacePossum
on 1 Feb 2018
@SpacePossum I did this table a while ago, and might be something to start with :smile:
carusogabriel
on 2 Feb 2018
Some of those are already in plase:
Slamdunk
on 2 Feb 2018
@Slamdunk Yes, a lot of them actually. I thought in a PhpUnitDedicateComparisonAssertFixer from the comparison operators table
carusogabriel
on 2 Feb 2018
what is column C ?
keradus
on 2 Feb 2018
@keradus Sorry, was a column to track the created ones. I removed.
Do you think we should have here, and is possible with Tokens? Also, is something to fix, or is more a refactoring?
carusogabriel
on 2 Feb 2018
remember that Fixer changes not only style.
We already do a lot of phpunit changes, one type is better assertions, other is migrate to newer phpunit version, definietly sth possible with Tokens.
keradus
on 2 Feb 2018
So I'll study and open a PR with some ideas :smile:
carusogabriel
on 2 Feb 2018
Related issues
EvgenyOrekhov
·
3Comments
kcloze
·
3Comments
CMalvika
·
3Comments
UksusoFF
·
3Comments
Bilge
·
3Comments
Most helpful comment
So I'll study and open a PR with some ideas :smile: