Php-cs-fixer: Special getter / setter / hasser cases for ordered_class_elements

[soullivaneuh]

I like the ordered_class_elements class fixer, but I would like to keep "pure" getters, setters and hassers at the end of my class, whatever the public / protected / private order definition.

Maybe could we add hierarchy options for that?

[keradus]

for me, it's too specific, :-1: unless you provide nice, generic solution

[soullivaneuh]

Having getters, setters and hassers option for function directly "linked" to the property is the more generic way IMHO.

Or I didn't understand your question. :wink:

[TomasVotruba]

@Soullivaneuh I think question was: how would you solve that?

[soullivaneuh]

@TomasVotruba Not sure to understand your question.

I talked about the option. After that I can work on some POC to see what is possible.

[TomasVotruba]

@Soullivaneuh It's been a while for me. I guess I was curious about specific approach that would make sense.

I'm personally fine with public/protected/private, ordered by use order.

E.g. while 1st public method uses 2 private methods, they should be in top of private methods.

[keradus]

big :-1: for that.
then, other public method would use that private, and code would be rearrange because of that :/

[TomasVotruba]

Nono, I don't want a fixer for that :+1: I'm fine with my hands and AI :smile:

[soullivaneuh]

What about keeping the default behavior and propose this as option? If you don't want to add exception, just don't activate them?

[keradus]

then https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/2746#issuecomment-299143522