Php-cs-fixer: [RFC] NoUnreachableCodeFixer

[keradus]

What do you think about fixer that would remove non-reachable code?

eg

before:

functinon foo()
{
    echo 1;
    return;
    echo 2;
}

after:

functinon foo()
{
    echo 1;
    return;
}

[hkdobrev]

👍 to have this. However I think this could be a risky fixer for some. It won't change what the code would do, but often unreachable code isn't intentional and people should actually run the code which is unreachable.

[keradus]

often unreachable code isn't intentional

agree

and people should actually run the code which is unreachable

why?

[phansys]

@keradus, I think it should be named "UnreachableCodeFixer" (instead of "NoUnreachableCodeFixer" which seems a contradiction for what you're proposing).

[keradus]

We name rules after state the code will follow after fixing. For all fixers. Just for consistency. So, after fixing, there should be no unreachable code.

[phansys]

Excellent then @keradus. Thanks for the clarification.

[SpacePossum]

             case 'directdebit':
                 return 'test';
                 break;

please let the fixer remove the break in these cases as well :)

[kubawerlos]

As much as having this fixer would be great I'm not sure it's worth the effort - would be very complicated and Vimeo's Psalm has --find-dead-code option to do exactly this.