Php_codesniffer: Incorrect indentation is actually correct

[NightJar]

Hi team,

I've recently made a JavaScript only update to a PHP module I help maintain, but then to my misfortune the CI build has failed stating that I have incorrect indentation in a file that has not changed.

This is an issue on a few fronts:

• the file is not altered
• the previous builds passed
• the indentation is actually correct

My colleague has identified that this seems to be a regression between 3.4.0 and 3.4.1

The build failure can be seen on TravisCI
The file related to this failure can be seen (at the correct commit) on my branch
The version of codesniffer can be seen installed at 3.4.1
The previous build of this module can be seen passing using codesniffer 3.4.0

Cheers

[jrfnl]

Tested and confirmed as duplicate of #2450 which was fixed by e3467d77d00955a0c55f75740c35db8185a6cf74. The fix will be included in PHPCS 3.4.2 which is expected reasonably soon.

[NightJar]

Thanks @jrfnl, sorry I didn't see the other issue while searching.