Php_codesniffer: Remove CSS and JS tokenizers + related sniffs

Created on 19 Mar 2019  路  4Comments  路  Source: squizlabs/PHP_CodeSniffer

Maintaining these tokenizers takes time, and they are not able to parse modern CSS and JS anyway, so they are pretty much useless. It's time to remove them.

Most helpful comment

I've now removed the tokenizers + all non-PHP checks inside sniffs + all JS/CSS test files + changed the ---extensions CLI arg to not allow passing a tokenizer.

All 4 comments

I absolutely agree. The modern software world contains various tools to check CSS and JS styles. PHP_CodeSniffer should focus on the right thing - the PHP programming language.

Is there a ballpark date for when 4.0.0 is expected to drop? Months? Years?

Is there a ballpark date for when 4.0.0 is expected to drop? Months? Years?

It's not years away, but it wont be this year. After 3.5.0 is released (hopefully in a few weeks) I'll get started on a 4.0 branch to begin the changes.

Even after 4.0 is release, I'll still support version 3 for a while with bug fixes and critical changes. How long depends on how many there are, but I try not to drop support until the bug reports for an old version basically stop coming in.

I've now removed the tokenizers + all non-PHP checks inside sniffs + all JS/CSS test files + changed the ---extensions CLI arg to not allow passing a tokenizer.

Was this page helpful?
0 / 5 - 0 ratings