Php_codesniffer: Inconsistently overrides command line arguments

Created on 8 May 2017  路  3Comments  路  Source: squizlabs/PHP_CodeSniffer

When ruleset.xml hard-codes command line values (e.g. <arg name="report" value="summary"/>) some can be overridden by command line arguments and some can not.

Enhancement

Most helpful comment

I rewrote that code in version 3 to allow CLI values to easily override those from rulesets, but obviously didn't finish putting it everywhere. I've done that now, and all CLI values will override or merge with those in rulesets.

All 3 comments

This creates problems like #1444

I rewrote that code in version 3 to allow CLI values to easily override those from rulesets, but obviously didn't finish putting it everywhere. I've done that now, and all CLI values will override or merge with those in rulesets.

Looks like this has been broken since v2 from the testing I did while updating specs for AtomLinter/linter-phpcs.

Glad to see it will be fixed! (even if it means another special case handling there 馃槢)

Was this page helpful?
0 / 5 - 0 ratings