Photos: New gallery App ignores generated previews

[GAS85]

Steps to reproduce

1. Do update from e.g. 17.0.4 to 18.0.3
2. Open new gallery app
3. See that previews are slowly shown
4. Click on one of the picture
5. See that original XXX Megapixel Picture transferred instead of pre generated HD preview

Expected behaviour

As before in NC 17 previews are pregenerated and show. Original picture could be downloaded by hitting download button.

Actual behaviour

Previews are ignored, original huge picture is shown.

Server configuration

Operating system: Ubuntu 18.04

Web server: Apache/2.4.41

Database: mysql Ver 15.1 Distrib 10.1.44-MariaDB

PHP version: 7.3.16

Nextcloud version: 18.0.3

Updated from an older Nextcloud/ownCloud or fresh install: update

Where did you install Nextcloud from: Official

Signing status:

Signing status

No errors have been found.

List of activated apps:

App list

Enabled:
  - accessibility: 1.4.0
  - activity: 2.11.0
  - admin_audit: 1.8.0
  - audioplayer: 2.9.0
  - bruteforcesettings: 1.5.0
  - calendar: 2.0.2
  - checksum: 0.4.4
  - cloud_federation_api: 1.1.0
  - comments: 1.8.0
  - data_request: 1.5.0
  - dav: 1.14.0
  - deck: 0.8.0
  - drawio: 0.9.5
  - federatedfilesharing: 1.8.0
  - federation: 1.8.0
  - files: 1.13.1
  - files_automatedtagging: 1.8.2
  - files_external: 1.9.0
  - files_mindmap: 0.0.20
  - files_pdfviewer: 1.7.0
  - files_retention: 1.7.0
  - files_rightclick: 0.15.2
  - files_sharing: 1.10.1
  - files_trashbin: 1.8.0
  - files_versions: 1.11.0
  - files_videoplayer: 1.7.0
  - firstrunwizard: 2.7.0
  - flowupload: 0.1.8
  - gpxpod: 4.1.1
  - keeweb: 0.6.2
  - logreader: 2.3.0
  - lookup_server_connector: 1.6.0
  - mail: 1.1.4
  - maps: 0.1.6
  - nextcloud_announcements: 1.7.0
  - notes: 3.2.0
  - notifications: 2.6.0
  - oauth2: 1.6.0
  - ocdownloader: 1.7.6
  - password_policy: 1.8.0
  - phonetrack: 0.6.2
  - photos: 1.0.0
  - polls: 1.3.0
  - previewgenerator: 2.2.0
  - privacy: 1.2.0
  - provisioning_api: 1.8.0
  - radio: 0.6.6
  - recommendations: 0.6.0
  - serverinfo: 1.8.0
  - settings: 1.0.0
  - sharebymail: 1.8.0
  - spreed: 8.0.5
  - survey_client: 1.6.0
  - systemtags: 1.8.0
  - text: 2.0.0
  - theming: 1.9.0
  - twofactor_backupcodes: 1.7.0
  - twofactor_totp: 4.1.3
  - unsplash: 1.1.5
  - updatenotification: 1.8.0
  - viewer: 1.2.0
  - weather: 1.7.1
  - workflowengine: 2.0.0
Disabled:
  - encryption
  - impersonate
  - sharerenamer
  - support
  - user_ldap

Nextcloud configuration:

Config report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": {
            "0": "***REMOVED SENSITIVE VALUE***",
            "2": "***REMOVED SENSITIVE VALUE***"
        },
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/***REMOVED SENSITIVE VALUE***\/nextcloud",
        "dbtype": "mysql",
        "version": "18.0.3.0",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "filesystem_check_changes": 0,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379,
            "timeout": 1.5
        },
        "mail_smtpmode": "smtp",
        "mail_smtpauthtype": "LOGIN",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "maintenance": false,
        "theme": "",
        "logfile": "\/var\/nextcloud\/data\/nextcloud.log",
        "loglevel": 1,
        "trashbin_retention_obligation": "14, auto",
        "versions_retention_obligation": "14, auto",
        "data-fingerprint": "***REMOVED SENSITIVE VALUE***",
        "enable_previews": true,
        "enabledPreviewProviders": [
            "OC\\Preview\\PNG",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\GIF",
            "OC\\Preview\\BMP",
            "OC\\Preview\\XBitmap",
            "OC\\Preview\\Movie",
            "OC\\Preview\\PDF",
            "OC\\Preview\\MP3",
            "OC\\Preview\\TXT",
            "OC\\Preview\\MarkDown"
        ],
        "preview_max_x": 1920,
        "preview_max_y": 1080,
        "auth.bruteforce.protection.enabled": true,
        "simpleSignUpLink.shown": false,
        "mail_smtpsecure": "tls",
        "mail_smtpauth": 1,
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "587",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "twofactor_enforced": "true",
        "twofactor_enforced_groups": [
            "admin"
        ],
        "twofactor_enforced_excluded_groups": [],
        "has_rebuilt_cache": true,
        "updater.release.channel": "stable",
        "app_install_overwrite": [
            "keeweb",
            "radio"
        ],
        "updater.secret": "***REMOVED SENSITIVE VALUE***"
    }
}

Are you using external storage, if yes which one: local, WbeDAV

Are you using encryption: no

Are you using an external user-backend, if yes which one: NO

[skjnldsv]

Hello :)
Using which view of the photos app?

[GAS85]

• Open Photo App, see that Previews are fetched - Ok
• Click on any photo, see that it is fetched from previews - Ok
• Click on "Your Albums" - Ok
• Click on any Photo - Original will be shown. - Not Ok.

[skjnldsv]

Thanks!

[GAS85]

I do small research and the same issue with:

• Shared Albums (index.php/apps/photos/shared/)
• Your Albums (index.php/apps/photos/albums)

[skjnldsv]

Yes, this is coming from the files we're giving :)
Moving to photos

[skjnldsv]

This is the code that calls the viewer: https://github.com/nextcloud/photos/blob/7bd7bf28808fc73bd2bfb09a352e7dca1c4c7938/src/components/File.vue#L122

I guess this is because in one we still use the usual dav endpoint, while we use the preview for the other? let's see

[hoellen]

I would like to see the preview as default behavior as well.
But as an idea, maybe it could be improved further:

• if the user opens the photo: show preview
• if the user zooms into the picture: the preview could be silently replaced by the original to improve quality

[jospoortvliet]

I would like to see the preview as default behavior as well.
But as an idea, maybe it could be improved further:

• if the user opens the photo: show preview
• if the user zooms into the picture: the preview could be silently replaced by the original to improve quality

I believe the original viewer did this? Or only mobile phone viewers maybe...

[tlinna]

I'd like to mention a special case where you don't want to fetch original images unless needed: Object storages such as S3.

E.g. I'm using S3 Intelligent tiering (or some other tiering system), which moves rarely accessed files into a cheaper tier storage until they are accessed again. In this case, I want to (pre)generate previews and store them locally (which is what happens now as far as I know) and only load the original image from S3 when the user actually needs it (clicks download button, zooms in further, etc).

[skjnldsv]

I would like to see the preview as default behavior as well.
But as an idea, maybe it could be improved further:

• if the user opens the photo: show preview
• if the user zooms into the picture: the preview could be silently replaced by the original to improve quality

That would be nice! :)
Thanks for sharing your improvement :+1:

[skjnldsv]

Fixed with https://github.com/nextcloud/photos/pull/509