Photos: Scrolling of already loaded photos is not smooth, previews get unloaded

[jancborchardt]

Describe the bug
Scrolling up and down through the list is not smooth as previews of previously loaded pictures get unloaded. The image filetype icon is shown and the preview is loaded again, leading to flickering.

To Reproduce
Steps to reproduce the behavior:

1. Go to any view
2. Scroll down
3. Scroll back up again, and down, and up

Expected behavior
Scrolling is nice and smooth, you ideally never see any picture preview loading – but especially not for ones which you already scrolled past and are scrolling back up to.

Screenshots
Here’s a gif:

Using latest Photos app master.

[skjnldsv]

Do you have the dev tools opened?

[jancborchardt]

Do you have the dev tools opened?

It happens with dev tools closed and opened, either way. What’s your question? ;)

[skjnldsv]

It happens with dev tools closed and opened, either way. What’s your question? ;)

if dev tools opened = cache disabled = force fetch all photos every time ;)

[Mikescops]

@jancborchardt can you confirm that it is no more the case with the latest master?

[skjnldsv]

Btw, nice mustachio @jancborchardt :grin: :heart_eyes:

[jancborchardt]

@jancborchardt can you confirm that it is no more the case with the latest master?

@Mikescops no, seems this still exists – here’s another gif of me scrolling up and down quickly:

[Mikescops]

@skjnldsv I bet this is our caching problem with N21

[skjnldsv]

@Mikescops seems so yeah

[Mikescops]

@skjnldsv to be honest i have removed the @loaded again and this issue is nearly unvisible, but I think we will need the worker cache as you suggested.

[skjnldsv]

but I think we will need the worker cache as you suggested.

https://github.com/mdn/sw-test/
https://developer.mozilla.org/en-US/docs/Web/API/Service_Worker_API/Using_Service_Workers#Promises

[Mikescops]

I think I will use Google Workbox, seems to be the most reliable implementation and has webpack support.

[skjnldsv]

Nice!
Remember the cache buster is the etag :)

[andyxheli]

Yup i have the same issue when loading photos as @jancborchardt

[ntimo]

Is there a change this gets backported to NC20?

[Mikescops]

Nope, this is for NC21 only due to the new grid we implemented.