Phonegap-plugin-barcodescanner: UPC_A codes now scans with extra 0 at the start

[jrobichaud]

Expected Behaviour

UPC_A should return 12 digits

Actual Behaviour

UPC_A returns 13 digits

Reproduce Scenario (including but not limited to)

Scan this code

Steps to Reproduce

1. Scan bar code with commit: https://github.com/phonegap/phonegap-plugin-barcodescanner/commit/68e7c05dd1a008deca8e4fc8a47b3c0169bcc01e
2. Scan bar code with commit: https://github.com/phonegap/phonegap-plugin-barcodescanner/commit/df54d51c029b3a35640ed32ae50325421c48db94

Platform and Version (eg. Android 5.0 or iOS 9.2.1)

Any iOS

(Android) What device vendor (e.g. Samsung, HTC, Sony...)

Any iOS

Cordova CLI version and cordova platform version

cordova --version: 6.4.0
cordova platforms:
 ios 4.2.1

Plugin version

It was introduced by this pull request: https://github.com/phonegap/phonegap-plugin-barcodescanner/pull/338

Sample Code that illustrates the problem

Logs taken while reproducing problem

[pbergner]

@macdonst was this issue resolved?

[macdonst]

@pbergner nope, not yet. I was able to reproduce it but did not get the chance to fix it.

[pbergner]

@macdonst oops, my fault i thought it was closed. I guess its still early (not really). I just ran into this issue as well.

[macdonst]

@pbergner yeah, I'm trying to give this plugin some more love as time allows.

[macdonst]

@pbergner @jrobichaud please install the latest from master and confirm it fixes your issue and I'll release a new version of the barcode scanner plugin once I hear back.

[jrobichaud]

@pbergner can you please do it? I am not set up to test this.

[pbergner]

@macdonst fixed for me! very similar to the workaround I had just put in place. Thanks!

[macdonst]

@pbergner yeah, I put it in the JS side for now and will retest when I update the ZXing library. I will publish 6.0.8 today or tomorrow.

[lock[bot]]

This thread has been automatically locked.