Phoenix: Info about running endpoints wrong

[benperiton]

Environment

• Elixir version (elixir -v): Elixir 1.7.3 (compiled with Erlang/OTP 19)
• Phoenix version (mix deps): 1.4.0 (phoenix) 56fe9a80
• NodeJS version (node -v): v10.3.0
• NPM version (npm -v): 6.4.1
• Operating system: OSX 10.11.6

Expected behavior

Using this config:

config :web, Web.Endpoint,
  http: [
    port: 3999
  ],
  https: [
    port: 4000,
    cipher_suite: :strong,
    keyfile: "priv/cert/selfsigned_key.pem",
    certfile: "priv/cert/selfsigned.pem"
  ],
  debug_errors: true,
  code_reloader: true,
  check_origin: false,
  watchers: [
    node: [
      "node_modules/webpack/bin/webpack.js",
      "--mode",
      "development",
      "--watch-stdin",
      cd: Path.expand("../assets", __DIR__)
    ]
  ]

It should show the correct ports for the endpoints that are running:

Generated web app
[info] Running Web.Endpoint with cowboy 2.5.0 at http://localhost:3999
[info] Running Web.Endpoint with cowboy 2.5.0 at https://localhost:4000

Actual behavior

Generated web app
[info] Running Web.Endpoint with cowboy 2.5.0 at https://localhost:4000
[info] Running Web.Endpoint with cowboy 2.5.0 at https://localhost:4000

[benperiton]

Looks like it might have been introduced in #3105 ?

[sionide21]

What would the expected behavior be if the config looked like the following?

config :web, Web.Endpoint,
  http: [
    port: 3999
  ],
  https: [
    port: 4000,
    cipher_suite: :strong,
    keyfile: "priv/cert/selfsigned_key.pem",
    certfile: "priv/cert/selfsigned.pem"
  ],
  url: [scheme: "https", host: "server.local", port: 4040],
  debug_errors: true,
  code_reloader: true,
  check_origin: false,
  watchers: [
    node: [
      "node_modules/webpack/bin/webpack.js",
      "--mode",
      "development",
      "--watch-stdin",
      cd: Path.expand("../assets", __DIR__)
    ]
  ]

It seems like it could go a few different ways:

• We could exclusively use the configured URL:

Generated web app
[info] Running Web.Endpoint with cowboy 2.5.0 at https://server.local:4040

• We could list all three:

Generated web app
[info] Running Web.Endpoint with cowboy 2.5.0 at http://localhost:3999
[info] Running Web.Endpoint with cowboy 2.5.0 at https://localhost:4000
[info] Running Web.Endpoint with cowboy 2.5.0 at https://server.local:4040

• We could replace one (I don't know which would be the correct one to replace though):

Generated web app
[info] Running Web.Endpoint with cowboy 2.5.0 at http://localhost:3999
[info] Running Web.Endpoint with cowboy 2.5.0 at https://server.local:4040

Or

Generated web app
[info] Running Web.Endpoint with cowboy 2.5.0 at https://server.local:4040
[info] Running Web.Endpoint with cowboy 2.5.0 at https://localhost:4000

[benperiton]

That is what is addressed in #3105 I believe, so the output should be (in my view)

Generated web app
[info] Running Web.Endpoint with cowboy 2.5.0 at http://server.local:3999
[info] Running Web.Endpoint with cowboy 2.5.0 at https://server.local:4000

[chrismccord]

Ah I see the issue now. Let's go with the "replace one" approach, where the configured URL scheme wins, so:

[info] Running Web.Endpoint with cowboy 2.5.0 at http://localhost:3999
[info] Running Web.Endpoint with cowboy 2.5.0 at https://server.local:4040

from your config. Thanks!

[sionide21]

I have a PR to make it match @chrismccord's example. https://github.com/phoenixframework/phoenix/pull/3152

I'm not sure if this is the right way to go though, it seems a bit confusing not to know the port you're actually bound too.

I wonder if it would be better to always use the hostname from url and always show the port we actually bound to. That would match what @benperiton has in their example.

[rmoorman]

Wouldn't it be better to explicitly state the configured url next to the endpoint's bound ip/port? Maybe for example showing https://localhost:4000 by default and in case a url is defined add (url set to https://server.local:4040) or something like that. This could imo make more sense to the folks reading the logs.

[sionide21]

This PR would match @benperiton's example above. https://github.com/phoenixframework/phoenix/pull/3158

[sionide21]

Wouldn't it be better to explicitly state the configured url next to the endpoint's bound ip/port? Maybe for example showing https://localhost:4000 by default and in case a url is defined add (url set to https://server.local:4040) or something like that. This could imo make more sense to the folks reading the logs.

Maybe the configured URL should be displayed completely separate from the listeners and we should just display what's bound here. For example:

Generated web app
[info] Running Web.Endpoint with cowboy 2.5.0 on 0.0.0.0:3999 (http)
[info] Running Web.Endpoint with cowboy 2.5.0 on 0.0.0.0:4000 (https)
[info] Serving Web.Endpoint at https://server.local:4040

[rmoorman]

@sionide21 that would be even clearer indeed IMO 👍 (I really like that the information needed to grasp what is going on regarding listening and url configuration is made visible)

[benperiton]

@sionide21 Yea, that looks pretty good - all the info is right there

[chrismccord]

@sionide21 that is a great idea! I would only s/Serving/Access and we are good to go!

[sionide21]

@chrismccord How does #3160 look?