Phinx: Status command: exit status code is 1 for both down migrations and uncaught exceptions

Created on 7 Mar 2016 · 6Comments · Source: cakephp/phinx

Currently, if running the status command causes an exception to be thrown which bubbles all the way to the top without being caught (like an InvalidArgumentException caused by a missing phinx.yml file on the FileLocator.locate() call), the script's exit code is 1.

The problem is that this is the same code as when there are down migrations (as per my merged changes from this PR), meaning there is no way of determining whether there really are down migrations or the command failed entirely.

I did some digging and I see that Phinx is not catching exceptions at all, meaning its down to the SymfonyComponent\Console\Application.run() method to decide the exit code, and it exits with 1 if there was an uncaught exception with code 0 (the default exit code for a InvalidArgumentException).

The way I see it, we can either:

Change the phinx error status code for down migrations from 1 to something else (maybe 3 since 2 is the code for missing migrations?).
- Pros: simplest option.
- Cons: not sure if it can be done in the next minor change release (in other words, is it considered a minor change?).
Surround the whole Phinx\Console\Command\Status.execute() method with a try/catch block and exit with a different code if an uncaught exception is (now) caught.
- Pros: definitely a minor change/bugfix.
- Cons: more complex, might not cover every case (what if there is an exception before or after the execute method?).