Phantomjs: Add information who or what initiated the network request (if any) to onResourceRequested

[vitallium]

Sometimes you need to know who or what initiated the network request.
It will be useful if we add this kind of information to our onResourceRequested callback.

[vitallium]

To implement this feature we need to assign a metadata to the QNetworkReply instance inside the WebCore.

[RReverser]

@Vitallium Just to show what I meant in relevant tweet - groups like in type options would be great.

[vitallium]

@RReverser yes, like in DevTools.

[RReverser]

@Vitallium Pretty much, yeah (although never checked whether they show the real initiator of just type of content - e.g. will <script src="image.png"></script> be shown as a script or as an image).

[ariya]

@Vitallium Is there already an upstream Qt bug (https://bugreports.qt.io/browse/QTBUG) filed for this?

[vitallium]

@ariya No. And I doubt if it will be there since they stopped developing QtWebkit.

[futurist]

What's the status/plan for this feature now? we need this feature in a project now. :smile:

[vitallium]

@futurist the plan is to implement it. But status is just TODO.

[wisec]

Hello @Vitallium ,
I would be really glad to have this feature implemented, how can I help/be involved on this?
Thanks

[wisec]

@Vitallium I would really like to help but I dont' know the call flow from OnResourceRequested and the WebKit method that gives the "type" info.
Would you be so kind to help me by giving me some direction so that I can start digging?
Maybe someone like @annulen can help giving some flow information on this?
Just as a head start - if possible.
Thanks a lot

[vitallium]

@wisec I doubt that we can implement that in the current state. But let me check the code to find out the way.

[wisec]

@Vitallium Can you elaborate why?
I am obviously considering this on PhantomJS +2.5

[vitallium]

@wisec this kind of information is available inside WebCore, not in QtWebKit layer. To pull this info you have to implement it (forward it) to QtWebKit layer.

[wisec]

@Vitallium I see... so I'm on my own :D I'll see what I can do then.
Thanks for your explaination

[annulen]

I guess this issue describes the same feature: https://github.com/annulen/webkit/issues/108

[wisec]

@annulen I guess so, thanks for pointing that out.

[jianghaizhi]

Is there any progress for this improvement?

[stale[bot]]

Due to our very limited maintenance capacity (see #14541 for more details), we need to prioritize our development focus on other tasks. Therefore, this issue will be automatically closed. In the future, if we see the need to attend to this issue again, then it will be reopened. Thank you for your contribution!