Pest: Allow usage of static closures

[olivernybroe]

When writing a test which contains no $this keyword, it would be awesome if we could define them as static.

it('can contain work', static function () {
    expect(Str::containsWord('test & word', 'test'))->toBeTrue();
});

[nunomaduro]

What would be the benefit from it?

[owenvoke]

Micro-op? 🤔 PhpStorm always is complaining to me about this.

[olivernybroe]

Yeah so the reason is basically that static functions are faster, which means static analysis would always recommend you to write it as a static function when possible.

With the usage of expect and so on we are actually not depending on $this, so it can be static 👍

[owenvoke]

Realistically, how much faster are they (genuinely interested if there's a good blog)? 🙂

[olivernybroe]

@owenvoke Read about it awhile ago, so can't remember the blog I found about it 🙂

However I don't think the performance difference is of any significance. This is mostly about satisfying static analysis, else all of the static analysis tools have to get a condition in for not checking for static functions in pest tests

[owenvoke]

Sounds good. 👍🏻 Thanks for the info.

[nunomaduro]

I've no plans on working on this. Feel free to submit a pull request.