Permissionsdispatcher: Support incremental compilation

[mannodermaus]

Gradle 4.7 introduced incremental annotation processing, or InCAP for short. Let's review if our use case can be applied here, so we can speed up project builds using this new incremental mechanism.

More info: https://docs.gradle.org/nightly/userguide/java_plugin.html#sec:incremental_annotation_processing

[hotchemi]

Yeeeah!

[meierjan]

Any updates? :)

[hotchemi]

umm sorry we haven't addressed 🙇

[autonomousapps]

Any update on this?

[hotchemi]

Dagger's issue: https://github.com/google/dagger/issues/1120
Commit: https://github.com/google/dagger/commit/6baf304a7c27e3ee43dbd0c942471fa510289008

[hotchemi]

PR: https://github.com/permissions-dispatcher/PermissionsDispatcher/pull/556
seems this doesn't work well with Kotlin? 🤔

[hotchemi]

Kotlin issue on Dagger: https://github.com/google/dagger/issues/1283

[autonomousapps]

Kotlin issue on Kotlin issue tracker: https://youtrack.jetbrains.com/issue/KT-23880

[tasomaniac]

One trick is to create a thin Gradle module at top level and keep it kotlin-free. Although that will only contain the top-level DaggerComponent, the generated code in the build is not so small. Keeping it java only at that level with only couple of java files already saves a lot of time.

[autonomousapps]

@tasomaniac can you elaborate on how much time is saved with that approach?

[tasomaniac]

I'm currently experimenting this with 2 projects. They are both small and highly modularized. Incremental build on 1 line change went from 12-15 secs to 7-8 secs. Since numbers are so small, I wouldn't trust.

In our big project, it is not easy to do this since the top module is heavy on Kotlin.

In short, you get rid of 3 tasks: kaptGenerateStubs, kapt, kotlinCompile and javac becomes incremental.

[autonomousapps]

Theoretically, this makes a lot of sense to me. I just want some good metrics. Might be a useful suggestion I can give people when they ask about improving Android build times. (I work for Gradle and one of my primary missions is helping Android teams improve build perf.) Thanks for the idea!

[hotchemi]

Thank you folks, let us know if there's something that is applicable to PermissionsDispatcher!

[tasomaniac]

Glad I could help @autonomousapps