Permissionsdispatcher: Support androidx fragment

Created on 9 May 2018 · 9Comments · Source: permissions-dispatcher/PermissionsDispatcher

Google released Jetpack that include Fragment class that the package name is androidx.fragment.app.Fragment. There might be other support library classes that need to change, too.

enhancement

Source

shiraji

❤1 👍1

Most helpful comment

I think I'd prefer if we waited until androidx.fragment:fragment graduates to a stable release before we change to it.

mannodermaus on 10 May 2018

👍2

All 9 comments

Thank you! Is it ok to proceed this this task from now right?

hotchemi on 10 May 2018

I think I'd prefer if we waited until androidx.fragment:fragment graduates to a stable release before we change to it.

mannodermaus on 10 May 2018

👍2

I asked a lot of googlers and finally reached to Yigit. He suggested to me that bump major version and drop support library support. If you really want, then split artifacts and let developers choose.

I like the idea dropping supporting old one, however since many developers use this library, I think we can support androidx like we did it for native fragment. I'm still not sure that default one should be Jetpack or not.

shiraji on 11 May 2018

Ah, you're referring to generating code for android.app.support.v4 or androidx based on what's available on the classpath? I like the idea, although I think that bumping the major version is a little cleaner. We could define a deadline dates for the current versions, after which we stop pushing fixes out to it, effectively its EOL. New stuff would go to the line backed by androidx.

mannodermaus on 11 May 2018

Any updates on this? I've forked your library in order to make my project compile again.
https://github.com/forkch/PermissionsDispatcher/commits/androidX