Peertube: Thumbnail aspect ratio does not match video aspect

[scanlime]

What happened?

Video thumbnails seem to all be hardcoded to 16:9, vertical videos appear stretched:

What do you expect to happen instead?

The thumbnail should occupy the same outer container as other thumbnails but the image itself should be sized to maintain aspect ratio.

Steps to reproduce:

1. Currently you can see this on https://diode.zone/videos/recently-added

Additional information

• PeerTube version or URL: 2.2.0
• Browser name/version: Chrome 84
• NodeJS version: 10.20.1

• Link to browser console log if useful:
• Link to server log if useful (journalctl or /var/www/peertube/storage/logs/):

[JigmeDatse]

Yeah, I noticed this when I uploaded some videos which are 9:16 aspect ratio 1080 by 1920 from the iPad...

[Chocobozzz]

What's the best way to handle these videos? Should we use black columns or zoom in the image?

[scanlime]

What's the best way to handle these videos? Should we use black columns or zoom in the image?

I would think neither... could this be handled in the CSS such that the actual page background shows through and the thumbnail is smaller yet fitting in the same bounding box as the 16:9 thumbnails. Zooming would almost always make the thumbnail unreadable i would think, and black bars seem unnecessary.

[JigmeDatse]

I feel if it could be handled that the image is just displayed within the 16:9 bounding box without affecting the aspect ratio would be best. This could result in some rather small thumbnails, but I'd rather that, and manually setting a thumbnail, than adding black bars (to the image), or cropping.

[chengjingfeng]

use black columns is acceptable