Peertube: RSS subscribe button downloads the XML file instead of opening it in a new tab on mobile

Created on 3 Nov 2019  路  13Comments  路  Source: Chocobozzz/PeerTube

This prevents easy RSS subscription on mobile. Plus, the link is not an actual link so it is impossible to just copy the target.

Type

Most helpful comment

Partially fixed in the upcoming release by making the link in an actual link. See: https://github.com/Chocobozzz/PeerTube/pull/2145

All 13 comments

Partially fixed in the upcoming release by making the link in an actual link. See: https://github.com/Chocobozzz/PeerTube/pull/2145

Why just partially?

If you click the button some browsers still want to download the XML file instead of displaying it inline (compare Chromium with Firefox to see the difference). By making it an actual link you can copy the target (on desktop: right-click 'copy link location).

This is the result of (mis)using file-extension like .xml on non-file content, like dynamically generated RSS feeds. If you want to do this properly, you have to do some webserver configuration, where you force display inline.

I would prefer that you would drop the RSS urls that end with a file extension and replace them by normal RSS subscription urls (like: http://example.com/id/rss). That would solve all problems, probably also the RSS autodiscovery "bug" in https://github.com/rigelk/PeerTube/issues/2 and any future problems with RSS subscription and discovery etc.

@frankstrater I think we can add other feed routes, and use them in the client if your think it will fix these issues

@Chocobozzz Yes, I'm pretty sure it will fix these and other future issues as well.

If you click the button some browsers still want to download the XML file instead of displaying it inline (compare Chromium with Firefox to see the difference). By making it an actual link you can copy the target (on desktop: right-click 'copy link location).

Or you can add a button that adds the link to your clipboard.

@frankstrater I tried with /feeds/xml/videos route, but firefox still wants to download the resource :thinking:

@Chocobozzz Just add a Copy link to clipboard button, man.

@frankstrater I tried with /feeds/xml/videos route, but firefox still wants to download the resource 馃

You might need to add something to the nginx configuration for this new route then. In my experience with Apache this would have worked, but it's probably something which is default base config for Apache relating to mimetype handling.

EDIT: or something needs to be added to/removed from the current HTTP headers which are set in the routing code

The mimetype served by the server is application/rss+xml, which while being the most correct per the RSS spec, is also the least supported by clients. Go figure. application/xml proves the most compatible and shows inline xml as asked.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kabo picture kabo  路  3Comments

XenonFiber picture XenonFiber  路  3Comments

Angedestenebres picture Angedestenebres  路  3Comments

XenonFiber picture XenonFiber  路  3Comments

ufm picture ufm  路  3Comments