Peertube: Friendica follow doesn't seem to be processed

[rigelk]

What happened?
Following a PeerTube account from Friendica (see https://github.com/friendica/friendica/blob/develop/src/Protocol/ActivityPub.php and https://github.com/friendica/friendica/tree/develop/src/Protocol/ActivityPub) results in an entry in the followersUrl column of the actor table, but no Accept activity is received on the Friendica side.

It doesn't prevent the follow to be processed, but maybe that is the sign of an error that prevents sendAccept to function.

We also tried a little further to experiment, since not receiving an Accept activity is not blocking Friendica to consider the account as followed: when publishing a video, the video is not seen by Friendica (logs show no request is made to the actor's inbox).

What do you expect to happen instead?
The Accept activity should be seen on the receiving end. New videos should be notified to the follower's inbox.

Steps to reproduce:

1. use https://github.com/friendica/friendica/tree/2018.12-rc

2. follow a PeerTube account (tested on december develop)

• PeerTube server log as seen in /var/www/peertube/storage/logs/ for the requests made upon follow from a Friendica account (here from pirati.ca run by @annando):

3725:{"message":"192.168.201.253 - - [29/Dec/2018:22:07:45 +0000] \"GET /.well-known/host-meta HTTP/1.0\" 200 2911 \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-29T22:07:45.683Z"}
3726:{"message":"192.168.201.253 - - [29/Dec/2018:22:07:45 +0000] \"GET /.well-known/host-meta HTTP/1.0\" 200 2911 \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-29T22:07:45.728Z"}
7907:{"message":"192.168.201.253 - - [30/Dec/2018:11:57:53 +0000] \"GET /.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:57:53.825Z"}
7908:{"message":"192.168.201.253 - - [30/Dec/2018:11:57:53 +0000] \"GET /.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:57:53.870Z"}
7909:{"message":"192.168.201.253 - - [30/Dec/2018:11:57:53 +0000] \"GET /accounts/.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:57:53.992Z"}
7910:{"message":"192.168.201.253 - - [30/Dec/2018:11:57:54 +0000] \"GET /accounts/.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:57:54.032Z"}
7911:{"message":"192.168.201.253 - - [30/Dec/2018:11:57:54 +0000] \"GET /accounts/root/.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:57:54.163Z"}
7912:{"message":"192.168.201.253 - - [30/Dec/2018:11:57:54 +0000] \"GET /accounts/root/.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:57:54.204Z"}
7913:{"message":"192.168.201.253 - - [30/Dec/2018:11:57:54 +0000] \"GET /accounts/root/videos HTTP/1.0\" 200 2911 \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:57:54.330Z"}
7915:{"message":"192.168.201.253 - - [30/Dec/2018:11:57:54 +0000] \"GET /accounts/root/videos HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:57:54.594Z"}
7916:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:12 +0000] \"GET /.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:12.414Z"}
7917:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:12 +0000] \"GET /.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:12.459Z"}
7918:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:12 +0000] \"GET /accounts/.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:12.586Z"}
7919:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:12 +0000] \"GET /accounts/.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:12.628Z"}
7920:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:12 +0000] \"GET /accounts/root HTTP/1.0\" 200 2911 \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:12.754Z"}
7922:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:13 +0000] \"GET /accounts/root HTTP/1.0\" 200 2049 \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:13.060Z"}
7923:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:13 +0000] \"GET /.well-known/webfinger?resource=acct:root%40dev.videos.lecygnenoir.info HTTP/1.0\" 200 234 \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:13.225Z"}
7924:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:13 +0000] \"GET /.well-known/host-meta HTTP/1.0\" 200 2911 \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:13.381Z"}
7925:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:13 +0000] \"GET /.well-known/host-meta HTTP/1.0\" 200 2911 \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:13.423Z"}
7927:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:45 +0000] \"GET /.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:45.303Z"}
7928:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:45 +0000] \"GET /.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:45.347Z"}
7929:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:45 +0000] \"GET /accounts/.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:45.488Z"}
7930:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:45 +0000] \"GET /accounts/.well-known/host-meta HTTP/1.0\" 404 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:45.528Z"}
7931:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:45 +0000] \"GET /accounts/root HTTP/1.0\" 200 2911 \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:45.678Z"}
7933:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:45 +0000] \"GET /accounts/root HTTP/1.0\" 200 2049 \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:45.981Z"}
7934:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:46 +0000] \"GET /.well-known/webfinger?resource=acct:root%40dev.videos.lecygnenoir.info HTTP/1.0\" 200 234 \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:46.149Z"}
7935:{"level":"info","message":"Fetching remote actor https://pirati.ca/profile/heluecht.","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:46.654Z"}
7936:{"level":"info","message":"Receiving inbox requests for 0 activities by https://pirati.ca/profile/heluecht.","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:47.773Z"}
7937:{"message":"192.168.201.253 - - [30/Dec/2018:11:58:47 +0000] \"POST /accounts/root/inbox HTTP/1.0\" 204 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T11:58:47.774Z"}
9072:{"level":"info","message":"Receiving inbox requests for 0 activities by https://pirati.ca/profile/heluecht.","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T13:38:10.422Z"}
9073:{"message":"192.168.201.253 - - [30/Dec/2018:13:38:10 +0000] \"POST /accounts/root/inbox HTTP/1.0\" 204 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T13:38:10.423Z"}
9074:{"level":"info","message":"Receiving inbox requests for 0 activities by https://pirati.ca/profile/heluecht.","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T13:39:51.258Z"}
9075:{"message":"192.168.201.253 - - [30/Dec/2018:13:39:51 +0000] \"POST /accounts/root/inbox HTTP/1.0\" 204 - \"-\" \"Friendica 'The Tazmans Flax-lily' 2018.12-rc-1292; https://pirati.ca\"\n","level":"info","label":"dev.videos.lecygnenoir.info:443","timestamp":"2018-12-30T13:39:51.259Z"}

[annando]

Friendica is sending this Follow request:

{
  "@context": [
    "https://www.w3.org/ns/activitystreams",
    "https://w3id.org/security/v1",
    {
      "vcard": "http://www.w3.org/2006/vcard/ns#",
      "dfrn": "http://purl.org/macgirvin/dfrn/1.0/",
      "diaspora": "https://diasporafoundation.org/ns/",
      "manuallyApprovesFollowers": "as:manuallyApprovesFollowers",
      "sensitive": "as:sensitive",
      "Hashtag": "as:Hashtag"
    }
  ],
  "id": "https://pirati.ca/activity/ec05c28caa702d46",
  "type": "Follow",
  "actor": "https://pirati.ca/profile/heluecht",
  "object": "https://dev.videos.lecygnenoir.info/accounts/root",
  "instrument": {
    "type": "Service",
    "name": "Friendica The Tazmans Flax-lily 2018.12-rc-1292; https://pirati.ca"
  },
  "to": "https://dev.videos.lecygnenoir.info/accounts/root",
  "signature": {
    "type": "RsaSignature2017",
    "nonce": "eb23597c01c281591ad5dbee080981c5ed40637f5ae6f7667d6a02ff8555d985",
    "creator": "https://pirati.ca/profile/heluecht#main-key",
    "created": "2018-12-30T13:39:51Z",
    "signatureValue": "iPI316Vre8/AIza/jPTu0i0+hyo+oGWyN1MsQRlHYp8qTtJaJQWuD8o9YDVI9bkOeDmjMUbXLhk8T5uUAhpqpiPztu7OpnprenYOlpwt4X+tk/+WubDkfX7Jxi50qlL8bbSCvc0RNkVH806DktCQBnZNTsAE0z1qlXa1lslLrHQdZAGxT4IlgwBgAdqGR6Q4nwMIz6svTPK07LQVz+Zw5SM9M1cHVy2fl1K1GCmGdPXF+ms/iN4YQuipcq13d/q/LfDpcCX/ScDSGbdnVsJFhjzcMBPuH2QyuClMEr9WGqY62+d3cMv6xfY0fvBQZF1k+oS4JziRbGI1zBF42tvvBehrf3+OjkilO4RBIDwYw/Pi6/8mPSUL7WYj1FXmHnh0geGoUxuSvBKF+TzS7gDZZWGkhUwwVcKXOqBpSu3iVfKYscBpXsNy7Eg8w2Gy7mzDI3fdQWdEs/PoQhViN5zjNOdC9E5FLAL7r+JrxUbLnQ4vzxjplwaKepx4reDmKFlf9zQUVRZqR4/F0Cvj+GsMYscvbG3Mr6neUGmiyjkpxDddk9aT6fs4UdDbWcNDAYbeIM5dkPWekokYlUo/LMpnVfHImlzAtkAYDMg4rnHhH4U2jK6WeoLe+8VGbBl2IJ4WWnCt9UnJ45EB431RtXTE1fhY5q4e2ViwEEvc1w7Pk9g="
  }
}

[annando]

What I can see is that the remote side does some profiling:

127.0.0.1 - - [13/Jan/2019:14:08:19 +0000] "GET /profile/test4 HTTP/1.1" 200 6038 "-" "-"
127.0.0.1 - - [13/Jan/2019:14:08:19 +0000] "GET /followers/test4 HTTP/1.1" 200 1101 "-" "-"
127.0.0.1 - - [13/Jan/2019:14:08:19 +0000] "GET /following/test4 HTTP/1.1" 200 1101 "-" "-"

So the follow request arrives there, the profile can be read and interpreted, but then something happens so that Peertube never sends an "Accept".

[annando]

BTW: When testing with Pleroma (on pleroma.soaykaf.com) and Mastodon (with mastodon.social), I had a similar problem, the connection request hadn't been accepted.

[Chocobozzz]

Fixed by https://github.com/friendica/friendica/commit/aa4aaf1971c7aa83db529a83369b619123ae703c

Thanks @annando