Peertube: Comment posted negative seconds ago

Created on 2 Dec 2018  路  7Comments  路  Source: Chocobozzz/PeerTube

I assume there may be a small time desynchronization between server and client, but in any case i don't think this is what we want to be displaying:

screen shot 2018-12-02 at 11 11 24 am

I'd expect we could solve this by rounding any times more recent than a couple seconds to "just now" or something, ignoring negative values effectively.

Type UI good first issue

Most helpful comment

@Chocobozz hi, sorry, I'll have to dismiss my contribution. I don't feel confident enough with this language. Sorry again :(

All 7 comments

I may work on this one this weekend

It seems it happens when publishing videos as well...
image

@Poslovitch any news on this? :)

@Chocobozz hi, sorry, I'll have to dismiss my contribution. I don't feel confident enough with this language. Sorry again :(

Hi, I'd like to fix this issue. I believe I've got a proper fix here. It uses Math.max to make a negative seconds result equal to zero instead. It also gets rid of a redundant Math.floor operation.

@zacharystenger thanks ! Please make a pull request.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Angedestenebres picture Angedestenebres  路  3Comments

Nutomic picture Nutomic  路  3Comments

XenonFiber picture XenonFiber  路  3Comments

gegeweb picture gegeweb  路  3Comments

filmaidykai picture filmaidykai  路  3Comments