The following blockers are identified for this:
Hello,
Just wondering if this is currently being worked on.
@timvandermeij
Thanks.
I would say that only the third point really needs fixing to avoid manual work in the release process. If that is fixed, we can make the release.
Identify which pull requests should still be merged for this release.
The following PRs would be nice to include (with their status):
Fix #11203 to avoid manual work during the release.
Once the above point is the only thing remaining, and depending on the complexity/time needed to actually address it (since it probably requires Brendan's help), should/could we consider doing the required clean-up manually (for this release too) such that the new release isn't unnecessarily delayed?
Yes, I'm fine with that if @brendandahl can do the fixup afterwards like last time.
After this release[1], the following diff ought to fix the https://mozilla.github.io/pdf.js/getting_started/ page:
diff --git a/docs/contents/getting_started/index.md b/docs/contents/getting_started/index.md
index 02618e82..eb49e4c8 100644
--- a/docs/contents/getting_started/index.md
+++ b/docs/contents/getting_started/index.md
@@ -49,6 +49,9 @@ Before downloading PDF.js please take a moment to understand the different layer
<a type="button" class="btn btn-warning HIDDEN_CLASS" href="https://github.com/mozilla/pdf.js/releases/download/vBETA_VERSION/pdfjs-BETA_VERSION-dist.zip">Beta (vBETA_VERSION)</a>
</span>
-->
+ <span class="GROUP_CLASS">
+ <a type="button" class="btn btn-warning HIDDEN_CLASS" href="https://github.com/mozilla/pdf.js/releases/download/vBETA_VERSION/pdfjs-BETA_VERSION-dist.zip">Beta (vBETA_VERSION)</a>
+ </span>
</div>
<div class="col-md-4">
<h3>Prebuilt (ES5-compatible)</h3>
@@ -63,7 +66,7 @@ Before downloading PDF.js please take a moment to understand the different layer
-->
<span class="GROUP_CLASS">
<a type="button" class="btn btn-primary" href="https://github.com/mozilla/pdf.js/releases/download/vSTABLE_VERSION/pdfjs-STABLE_VERSION-dist.zip">Stable (vSTABLE_VERSION)</a>
- <a type="button" class="btn btn-warning HIDDEN_CLASS" href="https://github.com/mozilla/pdf.js/releases/download/vBETA_VERSION/pdfjs-BETA_VERSION-dist.zip">Beta (vBETA_VERSION)</a>
+ <a type="button" class="btn btn-warning HIDDEN_CLASS" href="https://github.com/mozilla/pdf.js/releases/download/vBETA_VERSION/pdfjs-BETA_VERSION-es5-dist.zip">Beta (vBETA_VERSION)</a>
</span>
</div>
<div class="col-md-4">
[1] Eventually, these hacks can be removed and the code reduced to only the commented-out sections.
Hi @timvandermeij,
Just wondering if this is going to be released soon after skipping the third point
Fix #11203 to avoid manual work during the release.
Once the above point is the only thing remaining, and depending on the complexity/time needed to actually address it (since it probably requires Brendan's help), should/could we consider doing the required clean-up manually (for this release too) such that the new release isn't unnecessarily delayed?
The new release is made.
The new release is made.
@timvandermeij Thanks a lot for pushing this over the line!
Also, nice comment about the translated/non-translated builds on the release page :-)
You're welcome! It's a nice release and I'm glad that the release process worked better this time; pdfjs-dist
no longer has a duplicate commit. I'm only waiting for NPM to update the latest version number and then it all worked.
any updates on when the latest version will be available on NPM (I still see 2.3.200)
2.3.200 is the latest version. The 2.4 release is a beta. You can use the next
tag to test it.
thanks for clarifying!
Most helpful comment
The new release is made.