Pcl: Install Dependencies stage on CI does not fail when there are problems installing dependencies

[SergioRAgostinho]

The CMake configuration stage is failing to find Eigen on windows. This problem was originated upstream because we didn't change anything cmake that manifested in a build failure. I had a look at the commit history for vcpkg, nothing seemed to touch eigen in their latest commits.

See https://dev.azure.com/PointCloudLibrary/pcl/_build/results?buildId=110 for the build log.

We need some help @UnaNancyOwen .

[UnaNancyOwen]

OpenSSL is faild install, because Strawberry Perl site is down.
Therefore, some dependency libraries that require ssl for installation can't be installed.
Please wait until reboots Strawberry Perl site.

2018-11-30T11:24:45.4651936Z Starting package 74/95: openssl-windows:x86-windows
2018-11-30T11:24:45.4681489Z Building package openssl-windows[core]:x86-windows... 
2018-11-30T11:24:46.2538646Z -- Downloading http://strawberryperl.com/download/5.24.1.1/strawberry-perl-5.24.1.1-32bit-portable.zip...
2018-11-30T11:24:46.3579115Z -- Downloading http://strawberryperl.com/download/5.24.1.1/strawberry-perl-5.24.1.1-32bit-portable.zip... Failed. Status: 6;"Couldn't resolve host name"
2018-11-30T11:24:46.3581296Z CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:156 (message):
2018-11-30T11:24:46.3581520Z       
2018-11-30T11:24:46.3581579Z       Failed to download file.
2018-11-30T11:24:46.3581691Z       If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
2018-11-30T11:24:46.3581784Z       variables to "https://user:password@your-proxy-ip-address:port/".
2018-11-30T11:24:46.3581846Z       Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues
2018-11-30T11:24:46.3581913Z 
2018-11-30T11:24:46.3581968Z Call Stack (most recent call first):
2018-11-30T11:24:46.3582025Z   scripts/cmake/vcpkg_find_acquire_program.cmake:243 (vcpkg_download_distfile)
2018-11-30T11:24:46.3582112Z   ports/openssl-windows/portfile.cmake:9 (vcpkg_find_acquire_program)
2018-11-30T11:24:46.3582175Z   scripts/ports.cmake:71 (include)
2018-11-30T11:24:46.3582444Z 
2018-11-30T11:24:46.3582657Z 
2018-11-30T11:24:46.4761616Z Error: Building package openssl-windows:x86-windows failed with: BUILD_FAILED
2018-11-30T11:24:46.4761864Z Please ensure you're using the latest portfiles with `.\vcpkg update`, then
2018-11-30T11:24:46.4762349Z submit an issue at https://github.com/Microsoft/vcpkg/issues including:
2018-11-30T11:24:46.4762794Z   Package: openssl-windows:x86-windows
2018-11-30T11:24:46.4763637Z   Vcpkg version: 2018.11.23-nohash
2018-11-30T11:24:46.4764108Z 
2018-11-30T11:24:46.4764625Z Additionally, attach any relevant sections from the log files above.

[SergioRAgostinho]

Thanks for investigating. I'll close this since there's nothing we can do on our side.

Related:

• https://github.com/Microsoft/vcpkg/issues/3977
• https://github.com/StrawberryPerl/strawberryperl.com/issues/16

[SergioRAgostinho]

I just realized we have another problem then. The Install Dependencies stage should have failed and it didn't :/ What's the return value from vcpkg after failing to install?

[UnaNancyOwen]

Hmm, I don't know about that details.
@ras0219-msft @alexkaratarakis Can you give us advice?

[taketwo]

Seems like the builds are back to normal. However we still have this problem of not failing Install Dependencies stage, so keeping this open.

[alexkaratarakis]

@SergioRAgostinho
vcpkg returns EXIT_FAILURE when install fails. vcpkg generally doesn't rely on special error codes, it is either EXIT_SUCESS or EXIT_FAILURE + useful error message.
(very few exceptions)

[SergioRAgostinho]

Then my only theory is that Azure Pipelines only cares about the return value of the last execute command. In our case it would be

vcpkg list

which naturally doesn't fail.