Patchwork: Exif data removal, feature?

[wwwhtml]

Hi SSBC-Patchwork Folks,

First please excuse me if this is not the best avenue to suggest a feature, but I couldn't see any other place in the short search I did. I am in a hurry at this time, but I wanted to share this before I forget.

Anyhow, I have noticed that photos uploaded in Patchwork still have their exif data, is the exif data removal from images something that is already in your plans? If not, I feel it would be a nice feature to have, if possible.

Many thanks for you time reading this.

Daniel

[christianbundy]

Hey Daniel!

Anyhow, I have noticed that photos uploaded in Patchwork still have their exif data

Could you confirm which version of Patchwork this is happening on (and maybe your operating system)? I think this should have been resolved in 3.11.5, so it would be concerning to hear that this isn't working correctly. Thanks for opening this issue!

[wwwhtml]

Hey Christian, the version I am using is: 3.11.6 (3.11.6).

I just ran another test, on an image of someone else, and the exif data shows up.
The image was uploaded 9 months ago. I have an screenshot to show you, if you want to see it.

A second test that I just did was to upload and image I found online, and run the exif data check before and after I uploaded to ssb and the data still there.

[wwwhtml]

Not sure if this "&qyRiKeFlm4njLbrVB3/6ZrYQyNjvj8W0jH09XJ7EYp4=.sha256" is searchable. But it is of the test image I uploaded a moment ago and it shows its exif data as well.

[christianbundy]

Confirmed, it looks like the EXIF metadata removal isn't working correctly. I've opened an issue upstream: https://github.com/ssbc/ssb-blob-files/issues/6

Thanks a bunch for reporting this, it doesn't look like we would have found it any other way.

[wwwhtml]

Glad to be of some help.
(My second time finding something that needed fix.)

[wwwhtml]

@christianbundy, I installed the new beta version that you announced some 7 or so hours ago, 3.12.0-Beta-2, and check for the bug. Unfortunately the bug is still there.

&V3H2IbozqHVnT6bVDmpMirH7KrL9Ck2d6JQFg9/PkcY=.sha256

I am wondering if this is just happening on MacOS. Because I asked someone else to check one of the previous images and his posted results doesn't show the data. Just guessing.

Thanks.

[christianbundy]

Sorry for closing this without actually testing to ensure it was fixed in Patchwork, I was so certain that I understood why it wasn't working but I should have double-checked. I'll create another issue in the ssb-blob-files repo and hope we can figure out what's going on.

[arj03]

For removing exif we use piexifjs which sadly only works on jpg. So whatever metadata is embedded in the image must be something else than exif.

Edit: the image linked is png ;-)

[wwwhtml]

I suggest that, until the png data can be extracted, it should be warning message for those uploading photos/images; so they are aware.

[christianbundy]

@wwwhtml

That sounds neat, I'd love to merge a pull request for that. If you don't have time I'd love if you could open an issue as a feature request, maybe enumerating all of the places that this would need to happen? I know about the message composer and the profile photo chooser (for yourself and others), but there may be other places where we'd need this warning.

[wwwhtml]

@christianbundy

I feel that we should get request rolling, and keep it open for others to add more areas where the warming should come up. -I haven't look into what other areas need that warning, but the ones you listed it is a good start.

[christianbundy]

I don't have bandwidth for that at the moment, but I'm happy to support someone else working on it if you need any input from me.

[christianbundy]

Oops, I didn't see #1042, thanks for opening!