Patchwork: AppImage release causes segmentation fault under Ubuntu 18.10

[ericbarch]

When running any of the AppImage releases under Ubuntu 18.10, a segmentation fault immediately occurs.

I've reached out to another Patchwork user running Ubuntu 18.10 that also confirmed the issue (on a fresh install).

Here is the (truncated) output of LD_DEBUG=libs ./Patchwork-3.11.3-linux-x86_64.AppImage:

     18199: calling init: /usr/lib/x86_64-linux-gnu/libXcomposite.so.1
     18199:
     18199:
     18199: calling init: /usr/lib/x86_64-linux-gnu/libXrandr.so.2
     18199:
     18199:
     18199: calling init: /usr/lib/x86_64-linux-gnu/libXdamage.so.1
     18199:
     18199:
     18199: calling init: /usr/lib/x86_64-linux-gnu/libXcursor.so.1
     18199:
     18199:
     18199: calling init: /usr/lib/x86_64-linux-gnu/libXi.so.6
     18199:
     18199:
     18199: calling init: /usr/lib/x86_64-linux-gnu/libX11-xcb.so.1
     18199:
     18199:
     18199: calling init: /usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0
     18199:
     18199:
     18199: calling init: /usr/lib/x86_64-linux-gnu/libpangocairo-1.0.so.0
     18199:
     18199:
     18199: calling init: /usr/lib/x86_64-linux-gnu/libgdk-3.so.0
     18199:
     18199:
     18199: calling init: /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
     18199:
     18199:
     18199: calling init: /tmp/.mount_Patchw3ItDMR/app/libnode.so
     18199:
Segmentation fault (core dumped)

[christianbundy]

Thanks for this info! I saw in your SSB post:

In the meantime, I've been able to get v3.11.2 (not v3.11.3) running from the source repo. With node 6 and npm installed (using nvm), you can bring it up by executing npm i && npm start.

Could you post the issues you're having with v3.11.3 in the source repo? If you have Node 8/10 I might recommend trying with one of those.

[ericbarch]

No problemo 😃

As far as v3.11.3 is concerned, no messages ever appeared in the client when running under Node 6. FYI, I was using Node 6 because sbot seemed to always fail whenever I updated to newer versions.

The good news is that v3.11.3 works fine on Ubuntu 18.10 when running under Node 8.12.0.

[cryptix]

Your installed node version shouldn’t affect this at all. The electron inside the AppImage comes with it‘s own node environment.

If it is there is a major problem to be unearthed here, though.

[ericbarch]

Sorry for the confusion, @cryptix.

The issue reported is specific to the AppImage. The issue that @christianbundy brought up was related to running v3.11.3 via the repo. As my system is running Ubuntu 18.10 and the AppImage doesn't work, I've been running from source.

[christianbundy]

I think you might be getting burned by this: https://github.com/electron/electron/issues/13972

@mmckegg It looks like the latest AppImage is Electron 2.0.5, but I'm reading that this may be fixed by Electron 2.0.8. Would you mind releasing a new version of Patchwork with the latest Electron (currently 2.0.12)? Let me know if there's anything I can do to help with this.

[christianbundy]

I hacked together an AppImage that's just 3.11.0 but with the latest Electron -- this link should work for ~24 hours (or 20 downloads): https://send.firefox.com/download/07faaef37f/#zjQQQ3FYzpfwdJv8XtpHag

Maybe that will resolve the issue until we can get a full release?

[mmckegg]

Thanks for tracking this down @christianbundy. Will try and get a new release out later today.

[ericbarch]

Nice work, @christianbundy!

I just fired up your AppImage and it works great under 18.10. Sounds like we've got a fix.

[ghost]

This issue also occurs on Fedora 29 -- could Gnome 3.30 be the problem?

[christianbundy]

Maybe, but all the evidence that I've seen points to this being a glibc problem that's resolved in more recent versions of Electron. See this comment for more information.

@mmckegg If you're short on time, I'd be happy to make a new release with this update. Just don't want to step on your toes!

[mmckegg]

@christianbundy do you happen to have a mac build environment with the developer certificate? I think it would be very nice to share the load with the patchwork releases, but I think we should have a bit of a chat to discuss how to co-ordinate this.

The current state of patchwork releases is a little bit messed up right now, as I'm doing patches off the backfix-3.11.1 branch. There's still a couple more things I want to get done in the refactor (%pXYezAvNEV7JshH623MiEJJ+dLFTN/afLMfoA0USoDA=.sha256) before doing a full release off master.

I've been off ssb for the last few weeks, but hopefully get back into it soon. Maybe this afternoon!

[christianbundy]

do you happen to have a mac build environment with the developer certificate?

I had both in a past life, IIRC, but I don't have either anymore. I didn't really consider that, but it could definitely throw a wrench in the "me helping with releases" thing.

The current state of patchwork releases is a little bit messed up right now, as I'm doing patches off the backfix-3.11.1 branch.

Oh, didn't know that branch existed! I saw today on SSB that someone else mentioned this bug, so maybe even just releasing a backfix branch with an updated Electron may resolve it. Not sure. Either way, I'd be happy to help you out with releases or anything else in Patchwork. I'll shoot you my Signal contact info on SSB if you ever want to chat, but the whole not having a macOS device could make that difficult.

[mmckegg]

@ericbarch @christianbundy Just released Patchwork v3.11.4 with an updated electron version. Hopefully this fixes the problem. Closing!