Patchwork: infinite loading bug (patch-gatherings, TypeError: String.prototype.link called on null or undefined)

[ahdinosaur]

using f80296e49e5bd1b20ac5c2df3b224d7b61c2d43d

TypeError: String.prototype.link called on null or undefined
    at link (native)
    at ProtoSet._bind (/home/dinosaur/repos/ssbc/patchwork/node_modules/mutant/set.js:115:45)
    at ProtoSet.add (/home/dinosaur/repos/ssbc/patchwork/node_modules/mutant/set.js:51:53)
    at pull.drain (/home/dinosaur/repos/ssbc/patchwork/node_modules/patch-gatherings/gathering/obs/gathering.js:65:79)
    at /home/dinosaur/repos/ssbc/patchwork/node_modules/pull-stream/sinks/drain.js:24:37
    at /home/dinosaur/repos/ssbc/patchwork/node_modules/pull-stream/throughs/filter.js:17:11
    at callback (/home/dinosaur/repos/ssbc/patchwork/node_modules/pull-pushable/index.js:85:5)
    at Function.push (/home/dinosaur/repos/ssbc/patchwork/node_modules/pull-pushable/index.js:44:7)
    at notify (/home/dinosaur/repos/ssbc/patchwork/node_modules/pull-notify/index.js:10:20)
    at /home/dinosaur/repos/ssbc/patchwork/node_modules/pull-stream/sinks/drain.js:24:37

[ahdinosaur]

happens in patchbay as well

[mmckegg]

Yeah, it's everywhere!!! HAHA WHOOPS!

It's some dodgy message that I just published.

[ahdinosaur]

which message is the dodgy one?

@pietgeursen

[mmckegg]

Trying to figure that out. I've been rewriting gatherings to use ssb-about.

Must have done something bad. But it's working in my rewrite, so there's that.

Just about to publish it.

[mmckegg]

Found it:

{
  "key": "%Tnza+8RaPk3Mu3Vd8LMhhjqxc2j20CSrYHZq9re/jfY=.sha256",
  "value": {
    "previous": "%JGUwaoeN6IQHkiXP8HUxLEiJvEqNVWdMPemxaOkPxF0=.sha256",
    "author": "@FbGoHeEcePDG3Evemrc+hm+S77cXKf8BRQgkYinJggg=.ed25519",
    "sequence": 1913,
    "timestamp": 1497703400305,
    "hash": "sha256",
    "content": {
      "type": "about",
      "about": "%JGUwaoeN6IQHkiXP8HUxLEiJvEqNVWdMPemxaOkPxF0=.sha256",
      "image": "&yAEJ0AU2HWNzpXBOSX36PjG27ybPgeY3AQBKRfM+3wU=.sha256",
      "startDateTime": {
        "tz": "Pacific/Auckland",
        "valid": true,
        "bias": -720,
        "epoch": 1498694400000
      },
      "title": "Test Gathering",
      "description": "A test gathering"
    },
    "signature": "K7bKpUfO3K/a5pJoMoT2khBfThAxHXKt/hEF7fkPzMYdBnhpphRDa0sqv+hXZesWBbJzTeJUYWa0k+mhRGlOCQ==.sig.ed25519"
  }
}

Specifies image as blob string instead of link object.

[ahdinosaur]

oh, the failing line tries to get image.link, so is it %Tnza+8RaPk3Mu3Vd8LMhhjqxc2j20CSrYHZq9re/jfY=.sha256?

i'd say this is an error in patch-gatherings, since Patchwork already uses a string for image in normal about messages. see also ssb-msg-schemas/about.js.

[mmckegg]

yeah, definitely!

[mmckegg]

Everyone that has me as a FOAF and is using Patchwork v3.4.0 is going to get the infinite loading screen of death 😢

I guess we'd better push out Patchwork v3.5.0 sooner rather than later. Or people can downgrade to an older version.

[mmckegg]

Decided to go ahead and publish v3.5.0! Have macOS and windows builds up.

@ahdinosaur can you build for linux and then untick "prerelease"?

[mmckegg]

Also you might want to pull the latest patchwork-builder and npm install

[ahdinosaur]

@mmckegg okay will do. having a problem with sodium-native, will see if i can do something similar to https://github.com/ssbc/patchwork-builder/commit/116546d0b88c8ba93e695eca6ea2d7addc9a490d to get it working.

error loading sodium bindings: libsodium.so.18: cannot open shared object file: No such file or directory
falling back to javascript version.

[mmckegg]

@ahdinosaur oh yeah, I didn't even notice but looks like the macOS version has the same problem 😞

[mmckegg]

@ahdinosaur I think that ssbc/patchwork-builder@45be5c0aa4d3e5e2d1bc068c8d5666fd2eef8d78 should fix this!

[ahdinosaur]

yes, thanks! uploading meow. :cat2:

[ahdinosaur]

released! v3.5.1