Patchwork: re-implement i18n for Patchwork version 3

[ahdinosaur]

%mdlJLEUiWe+F0pqOmvKCnQDqo0vX5hJynfLgsdKm6rg=.sha256

translations from Patchwork version 2 ("Patchwork Classic") are in ssbc/patchwork-classic-translations

/cc @gmarcos87

[gmarcos87]

Hello, does it make sense that I finish translating? Or is it better to contribute in the re-implementation of i18n in v3?

[ahdinosaur]

@gmarcos87 it's up to you. if you feel comfortable helping with code, it's probably best to help with re-implementing i18n in v3, since then we know exactly what words and phrases are in the current interface. otherwise, you can continue with v2 translations, but keep in mind the words and phrases will likely change with v3. in general, it'd be really great to have you as our primary maintainer of the Spanish translations. :smiley:

[ahdinosaur]

regarding implementation, we need to pick a i18n library to help handle translation data and strings. here's what i can find, anyone have preferences?

• polyglot.js (used in Patchwork v2)
• format.js seems to be the most popular, we'd use intl-messageformat
• format-message
• nanotranslate very minimal

then we'll need to extract out all the current strings into a separate file and use one of these to format them back.

[ahdinosaur]

began writing a patch* module for internationalization: https://github.com/ssbc/patch-intl. will try and get this working with Patchwork so we can start extracting the current English strings into a locale.

[gmarcos87]

I had trouble understanding depnest :disappointed: . Anyway I extracted the text strings in English. If you show me how to implement only one translation I can do the same with the rest.
English strings: https://gist.github.com/gmarcos87/5a8e10903f01c3577ecc9d13aac21617

EDIT: My mistake. I just saw that there is the branch. https://github.com/ssbc/patchwork/tree/intl

[ahdinosaur]

hey @gmarcos87, great! https://github.com/ssbc/patchwork/issues/485 is ready to receive those English strings, do you think you can follow what i've done so far?

[gmarcos87]

Yes @ahdinosaur, sure. And if it's not hassle one of these days you can explain me by IRC how depnest works. If you do not mind. Thanks for the patience.

[ahdinosaur]

sweet. yep, but i'm not really on IRC much so can it be a thread here, on Patchwork, or a private Patchwork message? in short, depnest is syntactic sugar for writing depject modules, and depject is the module system used by Patchwork that supports overlapping opinions.

[dangerousbeans]

eep, didn't see this - I whacked together something crude here: https://github.com/ssbc/patchwork/pull/527

wasn't sure how to switch locale sensibly though

[ahdinosaur]

@dangerousbeans awesome. can you do this on top of https://github.com/ssbc/patchwork/pull/497?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.