Passport: Error handling

Created on 20 Sep 2016  路  3Comments  路  Source: laravel/passport

Http controllers have their own exception handler. In a trait.
Why?

This thing triggers only report method on the main ExceptionHandler and returns a plaintext response to the client without any chance to override.
Why?

There is some communication standard on every API and this error handling breaks it. Besides that, even in case of hard 500 it writes the error message to the client in plain text REGARDLESS the environment and production settings. All the SQL errors containing sensitive informations et vice versa are exposed.
GOD, WHY?

Only chance to override this is to write all the controllers again in project namespace. If these "prefabricated" controllers are here for making developer's life easier, why to hard-wire such crucial logic into them? Why not use a contract for injecting exception handler? If not, why not call the render method of application exception handler? Or anything else?

Regards,
RD

Most helpful comment

Why was this closed, the dude is right and nothing has appeared to have changed?

All 3 comments

Sorry for rudeness, guys, I was too pissed off by another things to think straight.

Anyway, what's your opinion to this error handling behavior in controllers? Or - in a better case - do you have any advice how to solve this? Maybe I overlooked something. All I'm trying to accomplish is get the error messages through application exception handler in formatted form (and filter-off sensitive data) without rewriting (or forking) it entirely.

Apologies and thank you in advance,
RD

I really don't like that all errors are caught in the HandlesOAuthErrors trait

Why was this closed, the dude is right and nothing has appeared to have changed?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cookiejarblush picture cookiejarblush  路  4Comments

brryfrmnn picture brryfrmnn  路  3Comments

s4uron picture s4uron  路  3Comments

gbgelado picture gbgelado  路  3Comments

duccanh0022 picture duccanh0022  路  3Comments