Parity-ethereum: Update ring to 0.13 or submit upstream changes
The version of ring currently in use within parity is a fork.
@tomaka, Is there any reason these changes have not been submitted upstream? If not, I, or someone on my team can take care of it. Please advise.
c0gent
All 5 comments
The reason why we used a fork is https://github.com/paritytech/ring/pull/1
I'm on my phone right now so can't really investigate but this change should be upstreamed if not done already.
tomaka
on 11 Sep 2018
I don't think it's a bad idea to have an issue for upgrading to ring 0.13. It's something we really want.
tomaka
on 12 Sep 2018
I think ring no longer defines __ANDROID_API__, see https://github.com/briansmith/ring/commit/08ec4f374caf1ef2bc079035642b89fbefdb5ed2.
ordian
on 12 Sep 2018
blocked by:
- [x] ipld/rust-cid#11
- [x] https://github.com/paritytech/parity-common/pull/58
ordian
on 12 Sep 2018
Just an FYI, here is the WIP branch which will update tokio/hyper (and everything else) to versions using ring 0.13: https://github.com/poanetwork/parity-ethereum/tree/c0gent-tokio. I'll finish it and submit a PR as soon as everything else is ready.
c0gent
on 14 Sep 2018
Related issues
gaoxiangxyz
路
3Comments
Michael2008S
路
3Comments
mr-older
路
3Comments
jacogr
路
4Comments
m-thomson
路
3Comments
Most helpful comment
Just an FYI, here is the WIP branch which will update tokio/hyper (and everything else) to versions using ring 0.13: https://github.com/poanetwork/parity-ethereum/tree/c0gent-tokio. I'll finish it and submit a PR as soon as everything else is ready.