Parity-ethereum: Creating separate repos for ethkey and maybe other crates

Created on 3 Jun 2018  ·  5Comments  ·  Source: openethereum/parity-ethereum

Hi,
I'm using ethkey for key generation, signing and other of the tools it provides inside my core.
I wonder why not put it in a different git repository and maybe even upload it to crates.io so it will be easier to use.
Right now I copied it manually so I'll need to update it manually because I can't even clone and update from upstream because it's a directory inside parity.

I think it would be better if every crate you have that is useful for others too will get it's own repo.

Thanks,
Elichai.

M4-core ⛓ P7-nicetohave 🐕 Z1-question 🙋‍♀️

All 5 comments

@elichai

Actually you can use ethkey directly by specifying the following in your Cargo.toml:

[dependencies]
ethkey = { git = "https://github.com/paritytech/parity.git" }

But yes, would probably be easier for everyone if it was published on crates.io

Will it work even though one of ethkey's dependencies is a relative path? ethcore-crypto = { path = "../ethcore/crypto" }

Yes, according to the cargo docs

Cargo will fetch the git repository at this location then look for a Cargo.toml for the requested crate anywhere inside the git repository (not necessarily at the root).

ok, I'll use that. although If you will make a different repository for great tools like that It would be great :)
(and the docs for ethkey can be better, maybe I'll try to make a PR for them )

:) PR in the wiki are always welcome: https://github.com/paritytech/wiki/

Was this page helpful?
0 / 5 - 0 ratings