Parity-ethereum: rlp module refactor

Created on 1 Mar 2018  路  6Comments  路  Source: openethereum/parity-ethereum

should fix issues like #8031 or #8032

  • rlp::decode should return Result<_, DecoderError>
  • get rid of Rlp
  • UntrustedRlp should be renamed to Rlp
F6-refactor 馃摎 P5-sometimesoon 馃尣 Q2-easy 馃拑 Q9-epic 馃尓

All 6 comments

issues is marked as easy and epic, cause it's easy, but time consuming

I'm looking at this

This is being split across several PRs, since lots of changes

Phases:

  • [x] Replace 'trusted' usages of Rlp with UntrustedRlp and handle Results, unsafely unwrapping where appropriate
  • [x] Convert ethcore views to use UntrustedRlp and handle Results
  • [x] Delete legacy Rlp and rename UntrustedRlp to Rlp
  • [x] Change decode to return Result<_,DecoderError>

Just the last bit needs doing now, changing decode to return Result<_, DecoderError>. I'll leave that here for now, I've unassigned myself for now so anyone else can pick it up or I'll come back to it later.

I'll have a stab at the decode changes. :)

All done!

Was this page helpful?
0 / 5 - 0 ratings