Parcel: Consider fixing security warnings (serialize-to-js)

Created on 12 Sep 2019  路  4Comments  路  Source: parcel-bundler/parcel

In a folder with latest parcel installed, yarn audit complains because of serialize-to-js (denial of service security bug).

Please consider upgrading to serialize-to-js@3 asap to fix this.

PS: I tried to clone the repo and upgrade dependencies myself to open a PR but:
1) simple yarn install emits a lots of errors with [email protected]
2) yarn upgrade-interactive --latest and then attempting to upgrade dependencies result in an infinite install loop (install, build script, build scripts fail, again install)

Most helpful comment

It's a valid issue if you use that function. Parcel does not.

Either way, I got annoyed enough at all the issues for this and released v1.12.4 with the update.

All 4 comments

This has already been fixed in master. And it never was a security issue npm secu just messed up again

Sent with GitHawk

Seems like a valid issue: https://github.com/commenthol/serialize-to-js/issues/7#issuecomment-492076598, right?

Deserialization of untrusted data using this package is dangerous. Even though it uses safer-eval to try and sandbox evaluated code, it is vulnerable to DoS by deserializing 'function(){while(true){}}()'.

Minimal viable sample:

const serializeToJs = require('serialize-to-js')
var str = 'function(){while(true){}}()'
var res = serializeToJs.deserialize(str) // will never finish
console.log(res)

It's a valid issue if you use that function. Parcel does not.

Either way, I got annoyed enough at all the issues for this and released v1.12.4 with the update.

@devongovett thank you x 1000 馃槈

Was this page helpful?
0 / 5 - 0 ratings