Parcel: Issue with parcel-plugin-* and map of requires?

[albinotonnina]

Possibly a 🐛 bug report

I'm testing my plugin to get inlined svgs instead of urls.

🤔 Expected Behavior

Below a screenshot of the build file:

😯 Current Behavior

Below a screenshot of the build file:

💁 Possible cause

I'm asking for help people!

I guess the issue is with the asset ids...

This is kinda random...
Building and building again (eg. just changing the order of the requires) sometimes will not print the duplicate 4 (expected behaviour) but most of the times the requires will have that same numeric require (100% the number 4 in my example) hence the current behaviour.
Numbers in general are sequential but often not (I don't know much about that, could you address me somewhere in the code?)
I'd like to start fixing this but I'd like to have a hint from you. Where to start? Is it my plugin? No idea yet. The plugin itself is very basic so far. Nothing fancy really.

💻 Code Sample

https://github.com/albinotonnina/parcel-plugin-inlinesvg/tree/master/example

🌍 Your Environment

| Software | Version(s) |
| ---------------- | ---------- |
| Parcel | any
| Node | > 8
| npm/Yarn | both :P
| Operating System | osx high sierra

Thanks!

[albinotonnina]

Same happens with another plugin https://github.com/fansenze/parcel-plugin-url-loader by @fansenze

[DeMoorJasper]

Does this still accure with latest master branch?

[albinotonnina]

@DeMoorJasper afraid so!

[fathyb]

I had the same on parcel-plugin-typescript (see #7). This is because two Asset.js are used, one from src and one from lib, it means that you'll get duplicated IDs. I did this as a workaround :

import JSAssetLib = require('parcel-bundler/lib/assets/JSAsset')
import JSAssetSrc = require('parcel-bundler/src/assets/JSAsset')

export const JSAsset = parseInt(process.versions.node, 10) < 8 ? JSAssetLib : JSAssetSrc

[DeMoorJasper]

Related to #251 , the api needs some improvements to expose more internal functions in a proper way

[albinotonnina]

Thanks @fathyb, it fixes for me too.

const JSAssetLib = require('parcel-bundler/lib/assets/JSAsset')
const JSAssetSrc = require('parcel-bundler/src/assets/JSAsset')

const JSAsset = parseInt(process.versions.node, 10) < 8 ? JSAssetLib : JSAssetSrc

Plugin fixed https://github.com/albinotonnina/parcel-plugin-inlinesvg

[devongovett]

Ah, ideally plugins wouldn't extend the internal asset types at all. The API should be better about allowing composition of assets.

[DeMoorJasper]

Closing due to inactivity and plugin api being rewritten in Parcel 2