Paper: Portal misses axis state

[Saharo4eks]

Link/paste of stack trace: https://pastebin.com/RmzMa17D

You can also simply just use code formatting in markdown!

___We need all of the stack trace! Do not cut off parts of it. Please do not use attachments. Upload your logs to a paste site or paste directly here.___

___Please do not make reports when the report says "DO NOT REPORT THIS TO PAPER". These are simply messages informing you of lag, to find what is causing it. Ask for tips on Discord or IRC instead.___

Plugin list:

Authme, boosCooldowns, ChatEx, ClearLag, CrazyAuctions, CustomJoinItems, DeluxeMenus, EssentialsX, EssentialsXSpawn, ExploitFixer, FastLeafDecay, FireworkLimiter, FishFix, FogusCore, GSit, HumsterAPI, HeadDatabase, HidePluginsProtect, IllegalStack, MoneyHunters, PermissionsEX, PlaceholderAPI, PlayerPoints, QuickBoard, RandomTeleport, SAML, ServerUtils, SkinRestorer, SmoothSpleep, TAB, Vault, WorldEdit, WorldGuard, WgExtender, zNPCs

Actions to reproduce (if known):

1. Creating a portal to hell
2. Go to hell and break the portal that has just been created
3. Teleport to the normal world with any command, for example /home (Essentials)
4. again go to the portal and the server crashes

P.S. this bug was discovered by the player, I - as the administrator could not repeat it. After logging in with the nickname of this player, the server crashed again. As if he's the only one who can paint.

Video on behalf of the player who crashed: https://imgur.com/a/GJNbi2c

Paper version:

Paper#141 1.16.2

[Saharo4eks]

Edit: I add actions to reproduce

[Chew]

1) Can you upload the crash report found here: /home/pp-suriva_l7m7z/public/./crash-reports/crash-2020-08-25_14.52.01-server.txt
2) Try reproducing without plugins, as this may be a plugin error

[Saharo4eks]

@Chew
crash-2020-08-25_14.52.01-server.txt
Without plugins the problem remains

[Chew]

(https://pastebin.com/qbCZNy2q Pastebin link)

[ClayCoffee]

I have the same issue.

[Chew]

@ClayCoffee even without any plugins?

nvm, guess it's accepted, proxi got this

[elwolf6]

same issue

[ClayCoffee]

@ClayCoffee even without any plugins?

nvm, guess it's accepted, proxi got this

yes

[Phoenix616]

This error seems to only be possible in two cases (could only confirm the first though):

1. The PortalCreateEvent is cancelled and therefore no block placed at the target. (This could be fixed by checking if the block has the value before trying to get it and if not return a default) I personally would prefer a contains check there instead of adding a new getOrDefault method like in the PR. Potentially there might be some other causes for the blocks not getting placed but I haven't seen that happening.
2. If the BlockUtil#a(BlockPosition, EnumDirection.EnumAxis, int, EnumDirection.EnumAxis, int, Predicate<BlockPosition>) method used when a portal got found from a cached POI somehow returns a rectangle with a wrong origin position. Unfortunately that code is beyond what I understand (right now) and I couldn't force that bug to happen without plugins to properly debug that :S

[FranckJohann]

Did you find a solution to the problem?

[NovaPixell]

I am also having this problem

[Phoenix616]

@NovaPixell what are your steps for causing this? Ideally without plugins.

[NovaPixell]

Simply enter the portal and the server crashes .. there was not something specific that triggered it

[Phoenix616]

Well please try to find out how to reproduce it and cases where it doesn't happen vs. cases where it happens. (E.g. old world, new world, certain server settings, upgrade path, etc.) as we still don't really know what causes this invalid state to occur as it shouldn't naturally (without plugins cancelling the create event as stated previously).

[NovaPixell]

Out of curiosity, are crash reports and console errors not enough? I can't do a test as I have a server with a lot of users. 13 days have passed since the opening of the issue and it is not clear how to solve?

[KennyTV]

Evidently not 👀 (and "as we still don't really know what causes this invalid state to occur as it shouldn't naturally")

[NovaPixell]

strange.. the only thing I can tell you are the positions and axis of the reference portals

[Saharo4eks]

I can tell you how it turned out that the server started to go down. The players wanted to dupe obsidian. They built and lit a portal in the normal world, teleported to hell, broke one block of obsidian in the portal so that it went out. Moved to the normal world with the command /home (Essentials) and re-entered the portal. Until some point, a new portal was created next to the broken one, but at one point this did not happen and because of this, the server goes into crash. I tried to repeat this bug at home, but it didn't work out. When I log in to this bug portal from my nickname, nothing happens, but as soon as I log in from the nickname of the Creator of this portal and log in to the portal, the server crashes. This bug occurs spontaneously and is tied to the nickname of the portal Creator.

[Saharo4eks]

If you can't fix the error at the moment, make a crutch. Forbid you to change the parameter that can cause this error through anything.as far as I understand, you have decided on this. The problem is that I have already 2 weeks players go to hell through 1 portal, located on spawn. Can you imagine what a shame that is?

[Proximyst]

We have not decided to merge a temporary fix; as it stands, it is not possible to reproduce without plugins interfering and as such we're not sure what the issue actually is. My PR to fix this issue may be updated later once it is known what the issue is.

[NovaPixell]

Guys I found the problem

[NovaPixell]

Basically I have always installed a plugin called NoNetherPortal, which blocks the switching on of the nether portals. Essentially, it is unknown for what reason, minecraft was trying to create a new portal in the overworld and therefore crashed as this plugin denied it to create and power on. In fact, without this plugin, the server has NOT crashed but has created a portal at random, without connecting to its original one. But then I was able to re-link the portals as they were before.
Could you be interested in the plugin? Maybe somehow you can figure out the source problem from this?

[NovaPixell]

So, I don't want to say bullshit, but this crash is caused by a plugin or something blocking the creation of portals

[NovaPixell]

Will some mechanics be changed with 1.16.2, can you fix it with Paper?

[Phoenix616]

So, I don't want to say bullshit, but this crash is caused by a plugin or something blocking the creation of portals

That is already known, see my previous comment. The main issue here is the crash causing without any plugin installed.

[Chew]

Not sure what the deal is with the 👎 Nova, he made a valid point. This is a real issue, and even if a a plugin is corrupting something, we should prevent that from happening.

[NovaPixell]

no no, I agree. the thumb down was to say like "it's a very serious problem and I'm sorry", even if I had to put the thumb up xD

[Chew]

Ah okay, lol, yeah, hopefully they figure it out

[NovaPixell]

ahah

[TNTUP]

Happens with Spigot:tm: aswell, not a paper issue

[NovaPixell]

I think that is a Minecraft Bug, I was affected by this bug unfortunately. Virtually every portal from the overworld always created a new portal in the nether in random locations with each server restart. https://bugs.mojang.com/browse/MC-149705

[Proximyst]

@NovaPixell That bug and this are not the same.

[Chew]

You're thinking #4266, and it has been brought up there.

[Proximyst]

Fixed in 44e822f

[lockerecca]

Thanks for fix!