Paper: Reduce the size of paperclip

[pczmr8v5n454iycf]

Is your feature request related to a problem? Please describe.
paperclip is so big that I doubt if it is a patch instead of complete class files which break the GPL's linking clause.

Describe the solution you'd like
Reduce the size of paperclip

Describe alternatives you've considered
none

Additional context
none

[simpleauthority]

You doubt? Why don't you go look at the code and quell that doubt? It's not like it's hidden from you. We're not breaking any GPL linking clause.

edit link: https://github.com/PaperMC/Paperclip

[MiniDigger]

You can see exactly what its doing if you want:
https://github.com/PaperMC/Paperclip/blob/master/java8/src/main/java/io/papermc/paperclip/Paperclip.java#L142
https://github.com/PaperMC/PaperclipMavenPlugin/blob/master/src/main/java/io/papermc/paperclipmavenplugin/GenerateDataMojo.java#L112

[pczmr8v5n454iycf]

@simpleauthority I have read it before. I doubt if jbsdiff can generate effective patch for jar files.

[Proximyst]

Then you help them improve; this is not an issue for Paper nor Paperclip in that case.

[pczmr8v5n454iycf]

@Proximyst jbsdiff is not designed to create patches for jar files

[simpleauthority]

Then suggest an improvement. We're an open source project after all. What do you believe is better?

And "effective"? What does that mean in this context? It certainly is effective, because it works.

[Proximyst]

It's clear that you didn't even attempt to check what bsdiff is. bsdiff is designed to make patches from and apply patches to any kind of file. It's made for binary files, therefore it applies to all files.

[pczmr8v5n454iycf]

@Proximyst I knew what bsdiff is. It's designed for executable binaries but not zip.

[simpleauthority]

Binaries are binaries.

[Proximyst]

Make a better solution, then. A zip file is still diff-able as a binary after all.

[pczmr8v5n454iycf]

@Proximyst Yes. Removing all bytes and adding some other bytes is technically diff.

[Draycia]

@Proximyst Yes. Removing all bytes and adding some other bytes is technically diff.

And?

[pczmr8v5n454iycf]

@simpleauthority Executable http://www.daemonology.net/papers/bsdiff.pdf

[Proximyst]

Binaries are binaries no matter what they were made for. If you believe there's a better way, make a proof of concept for zip file patching which results in smaller binary sizes at little (negative) performance impact, or higher performance at little (negative) binary size impact.

[mikroskeem]

The PDF is focusing on executables, but nothing says that bsdiff is not suitable for overall binaries (or simply a blob of data - in this case what Paperclip is doing).

[pczmr8v5n454iycf]

@mikroskeem But bsdiff is just not suitable for Paperclip

[simpleauthority]

Why?

[Proximyst]

Me, 4 minutes ago: https://github.com/PaperMC/Paper/issues/3586#issuecomment-646974737

If you believe there's a better way, make a proof of concept for zip file patching which results in smaller binary sizes at little (negative) performance impact, or higher performance at little (negative) binary size impact.

[pczmr8v5n454iycf]

@simpleauthority Because the size is too big compared to the patched jar