Paper: Extreme mob spawn counts

[jordanwilliams1]

Guardian Farms are fucked... I Went to a players Guardian Farm, I Nearly crashed. They crashed and the server tps was at 5 and dropping.

The Guardian Farm had over 250 Guardian's in there and just kept spawning...

How to make this bug, Build a Guardian Farm or just go to a Guardian temple, My server was running 100% fine on spigot, I Updated to Paper today because i was told it will improve my server.... -_-

Proof:

Guardian Farm: https://i.gyazo.com/dbd0c31d7aa4e9d81c127d6f2b0be402.png

TPS: https://i.gyazo.com/c0c948b6d424d9df9cd2da52e89a2fcc.png

Update: (This is for all spawns, Not just Guardians)

[jordanwilliams1]

Bukkit.yml: http://pastebin.com/J4xFskvw
Spigot.yml: http://pastebin.com/miLMcurL
Paper.yml: http://pastebin.com/VrZ1WFRM

Another screenshot, Tps now 1 :)
https://i.gyazo.com/592873ec16eeaecb34185cab715b88f3.jpg

[jordanwilliams1]

Running latest version of paper ^^

[andris155]

Use ClearLag chunk-entity-limiter.

[jordanwilliams1]

That's not going to help, Spawns everywhere are fucked, I'm not using paper till this is fixed.... And I do have a chunk entity limiter of 150.. There was over 900 mobs there at one point

[zachbr]

I still can't reproduce this despite getting a growing number of reports on it :(

[UnfixableExploit]

why not disable Guardian Farms until it can be reproduced or test new builds every week or something on a local - test server to see if its fixed :dancer: :dancers: :8ball:

[zachbr]

Reformatting as general entity spawn issue, as that's the report I keep getting. I don't believe this issue is specific to Guardians.

[zachbr]

From GH-150:

"Bukkit: http://pastebin.com/bJATVP17
Spigot: http://pastebin.com/Xy4wumJE
Paper: http://pastebin.com/gt6TLDe6
Timings: http://timings.aikar.co/v2/?id=0337f2b500694c64ad1e8baf5bd9278c
Plugins (49): MobEggSpawnerBlocker, PlugMan, NametagEdit, MineMarket-Universal, ChatColor, AsyncWorldEditInjector, CoreProtect, Deadbolt, SkinsModule, LimitCreative, CreativeNbtControl, ClearLag, ChatControl, Chairs, ProtocolLib, NoCheatPlus, LibsDisguises, AsyncWorldEdit, IPWhitelist, OldGoldSurvival, RedstoneClockDetector, PermissionsEx, Vault, FamoustLottery, FwdMsgChanger, MyCommand, PlayerHeads, WorldEdit, Essentials, PlotMe, Jobs, Auctions, Multiverse-Core, TreasureChest, EssentialsChat, MobArena, WorldGuard, EssentialsGeoIP, LimitedCreative, EssentialsSpawn, PvPManager, RedstoneClockPreventer, TitleManager, iZone, AreaShop, SurvivalGames, CraftBook, ChestShop, MyPet"

[frash23]

I'll start a test server with those plugins and see if I can replicate the issue, and hopefully figure out what plugin is causing it.

[andris155]

[frash23]

Unable to reproduce so far. I'll test some more tomorrow.

[MatthewM]

I'm only seeing this on a world that's from 1.8.8 might be related.

Edit: Could this be related to Multiverse-Core?

[hurrgurl]

Any wild ideas what I can try to look for in order to reproduce it reliably?

Could occasional mass use of Entity::remove mess with paper's removing of entities?

@MatthewM
No Multiverse-Core here, but world was V1.7 > V1.8 > V1.9.

Do you experience no issues with fresh 1.9 as compared to 1.8>1.9 world update?

[hurrgurl]

Small update, hopefully I'm going in the right direction.

Standing in one place for ~3 hours (AFK overworld) created 171 entities.
I have monster spawners completely disabled, so that shouldn't add any extra entities.
Not sure if location matters but I was at Y86 Extreme Hills+ biome on top of some mountain.
Paper dispawn ranges are set to 32 and 64, chunk load distance is 5.

My bukkit passive mob limit is set to 10 and 50 hostiles. Water & ambient is set to 1.
That particular world was updated from 1.8 to 1.9. I was AFKing in chunks that have been generated in 1.9 though.

[ghost]

Mine isn't as bad as some of the above, but I too am getting way more entities than normal spigot:

WG Report:
http://pastebin.com/e81qT5TF

I have animals limited to 7 and set to spawn every 800 ticks and they are still extremely high.

[hurrgurl]

My worldguard wont show entity distribution for some reason. QQ

[MatthewM]

@hurrgurl yes, 1.9 clean seems to not have the issue. It's something about it going from 1.8->1.9 then I guess

[ghost]

Are we just out of luck if we have a 1.8 generated map on 1.9? :/

[zachbr]

The bug isn't closed, it is on the todo list.
The issue is that even on 1.8 genned worlds this issue isn't consistent, so we can't reproduce it whenever we like. Which is why it's labelled as such, and as "help-wanted". Feel free to take a look when you get time.

[RoboMWM]

It's something about it going from 1.8->1.9 then I guess

No issues on my end, I've updated my server from 1.8.8 to 1.9.2 with no issues like these as far as I'm aware. My server is in hard mode.

However, I don't use WorldBorder nor a pre-generated world (world is probably 3 years old at this point)

[Gabscap]

I have a world generated with 1.9 and I'm also affected by this bug.

[BestMark]

Save problem after WorldBorder fill.

[ghost]

It's only happening in my world(s) that were generated with WorldBorder's fill command as well ^

[akarras]

I too am experiencing this issue in worlds generated by WorldBorder's fill command. Seems like a common theme

[Brokkonaut]

We have this problem too - Restarting the server helps for a while but after some time the extreme mobspawning begins again.

[jordanwilliams1]

I Would also like to add that my world was generated by world border and I'm currently getting the bug :P

[RoboMWM]

I've updated my comment to include the fact that I did not pregenerate my world with WorldBorder (nor do I use it), and am not having this issue afaik.

[sweepyoface]

[jordanwilliams1]

Has any progress been made on fixing this bug yet :( ?

[hurrgurl]

Having no/next to no issues on clean 1.9 world.

[MatthewM]

I'm assuming all of us have worldguard.. what version?

[hurrgurl]

Why would WG be relevant to this?

Also WG didn't have any big updates for months.

[MatthewM]

I noticed WorldGuard in the high resource offenders and it trying to deny spawns. I'm updating WorldGuard to this build right now.

[erik1988]

I also had this problem, I installed paper yesterday and today it was passive mobs everywhere, I did not add any plugins or changed any settings in the meantime. Today I reverted back to normal spigot an the problem seems to be gone. In other words this is defiantly caused by having paper installed, if there is because of paper itself or because of the way it modifies other plugins is unknown to me, but I do know this is not a problem in normal spigot - all things being equal.

This was my config (and plugins) when paper was installed:
http://timings.aikar.co/v2/?id=a900a03c9cad4c30ac644c4f53904050&section=config

[dwilley83]

Did the different build of WG seem to help this issue? I have also switched us back to Spigot after installing Paper because of the passive mob explosion. I installed our world, plugins, and 1.9.2 version of Paper on a test server and afk'd on there for an hour or so and didn't seem to have the issue but hard to tell since there was several players online on our actual server at the time the problem was happening. Also, the test server I made was setup before we switched our 1.8.8 world to 1.9, which was the reason for setting up the test server in the first place. I hadn't done WB fill on the test server because it had been done in 1.8.8 already and didn't think I'd need to. But wb fill has been ran on our actual server since the 1.9 update. I'm all up for trying things to fix this because we liked how the server was performing with Paper installed and are looking to switch back to it once this mob issue is resolved.

[stevmei]

@Zbob750

I've send you my world directory in which I'm getting a lot of passive mobs.
Maybe it is caused by one (or all) of the following aspects:

• (Dirt) Blocks are not checked for air above when trying to spawn mobs, because the only world I am experiencing this is a world that has no underworld, just heigth 0 to 64 dirt
• Some limitations are ignored when spawning mobs
• It takes a whilte to spawn so many mobs, they aren't appearing in an hour. It takes > 10 hours for this:

http://imgur.com/HyTaKAO
http://imgur.com/FY2SLCz

[dwilley83]

That makes sense because I had installed Paper on our server at around 5 AM and it ran with it all day and that night me and my co-admin had decided to switch back to Spigot because of all the passive mobs and went on a mass slaughter. It seemed to affect the spawn area worse than anywhere else but we have people going through the spawn area all the time which could have caused that part of it.

[dwilley83]

I wish I still had the timings reports we had taken but at this point I feel like all the timings reports are going to pretty much look the same when the problem is happening.

[zachbr]

All affected please update to build _681_ or higher. Don't waste our time with outdated versions.
Will re-open if needed
Thanks

EDIT: Use build 681 or newer

[zachbr]

Did not fix

[aikar]

I found some bad logic issues with spigots changes. Hopefully this resolves it. Let us know and reopen if not.

[Brokkonaut]

The change does not fix the bug. I wrote a small plugin to look for the causes of this bug and the cause are negative mob counts in the entityCount Map in the chunks. I don't know why this values can become negative, but somehow they do..

[Brokkonaut]

http://pastebin.com/5cZJt1Qj
is the (test-)output of this code:
http://pastebin.com/TrcSP8bs

[jordanwilliams1]

So... This isn't fixed, yet its "Closed" -_-

[aikar]

@jordanwilliams1 its automatic when we link issues and we think its fixed, so we then reopen them when its found not to be.

Thats a very good find @Brokkonaut

It is very possible a plugin is using NMS and corrupting the counts.
Will check into it later when home to see if any possible flaw in the counting code (i've got theories on some)

[TNTUP]

Server crashed with this: https://hastebin.com/usuhawolov.coffee

I've disabled mob-spawning in Global and then enabling in some regions with WorldGuard, I guess it caused this crash, so maybe that's the mob issue? (With WG)

[RoboMWM]

Server crashed with this: https://hastebin.com/usuhawolov.coffee

I've disabled mob-spawning in Global and then enabling in some regions with WorldGuard, I guess it caused this crash, so maybe that's the mob issue? (With WG)

This seems to be unrelated to the issue.

[TNTUP]

Thought it would be, sorry^^

[Puremin0rez]

For those having the issue, try the latest build of Paper as of the time of this post. (#684 or higher)

More fixes made in regards to this issue from @aikar

[dwilley83]

I ran #682 on my test server tonight and was on there for about 2 1/2 hours and the passive mobs were everywhere so I don't believe it's fixed.

[Puremin0rez]

Build 682 does not have the new entity spawn fixes that were made in the past few hours. You need to be using at least #683 to benefit from these newer changes.

[TNTUP]

Anyone running with Libs Disguises, unload it and watch your entity count going back to normal! It fixed on my end! But I cannot endorse if it doesn't work or nor you don't have it?

@dwilley83 Any chance you have Libs Disguises installed?

[Brokkonaut]

@TNTUP I don't have LibsDisguises at all on my server, so at least it cannot have been the only source for this bug.
But just update Paper as it is fixed now.

[TNTUP]

@Brokkonaut Glad to know! I've updated aswell, without Libs, I'll try it tomorrow or later today!

[dwilley83]

Updated to #684 yesterday on my test server and afk'd for about 3 hours and no mobs, passive or hostile, were spawning at all. This morning I have installed #685 and I am trying that one out. So far I've had some hostiles spawn so we'll see how it goes.

[TNTUP]

At peak times @dwilley83 ? I'm on the #685 too :)

[dwilley83]

My test server only has me logged in on it right now.

[TNTUP]

Okay^^

[dwilley83]

What is going on with the link to download newer versions? Site seems to be down?

[zachbr]

https://twitter.com/PaperPowered/status/722064350685569024

Temporary mirror has been provided here

[stevmei]

Running build 684 since 2 days - no passive mobs spawning (only a few, acceptable amount). Seems this issue is fixed, thanks for all providing informations and many thanks to @aikar and @Zbob750 for fixing!

I guess this could be closed :)

[aikar]

Thought I did close this :P

[TNTUP]

Running Libs yesterday, without issues now. Guess now Paper fixed it! You're a hero Aikar!: P

[Techcable]

Pretty sure 845090e5704a14e662de109451d62f814c439c2f is the exact commit that fixes the issue.
The problem is apparently plugins messing up mob counts.
Thanks @aikar :p

[TNTUP]

Solved on my side, been running since 4 days and no huge TPS drops! Aikar our hero :package: