Pants: Support git+https / git+git style dependency in 3rdparty Python

[leozc]

in requirements.txt
git+https://github.com/daviddrysdale/python-phonenumbers.git@daed536e4c90438f78e70f3a2b2f2f4421f0f15d#egg=python-phonenumbers

OUTPUT:

Exception caught: ()

Exception message: ('Expected version spec in', 'git+https://github.com/daviddrysdale/python-phonenumbers.git@daed536e4c90438f78e70f3a2b2f2f4421f0f15d#egg=python-phonenumbers', 'at', '+https://github.com/daviddrysdale/python-phonenumbers.git@daed536e4c90438f78e70f3a2b2f2f4421f0f15d#egg=python-phonenumbers')
while executing BUILD file BuildFile(3rdparty/python/BUILD, FileSystemProjectTree(/foo/repo))
Loading addresses from '3rdparty/python' failed.
....

[kwlzn]

this is essentially a duplicate of https://github.com/pantsbuild/pex/issues/93 + a pex release and version bump.

[cburroughs]

Also related: #2679

[ghost]

@kwlzn @cburroughs I'd like to work on this. We use pants to package Python and this has been an issue for us. Have there been any plans on how this needs to be implemented?

[kwlzn]

@copyconstructor that'd be awesome - have heard of at least a few folks wanting this feature recently.

afaict, no plans have been discussed. however, the meat of the change would happen against pex - the library that pants uses under the hood to build python artifacts. the tracking issue under pex is: https://github.com/pantsbuild/pex/issues/93

once this lands in a pex release, the scope of this ticket for the pants-side consumption should be more or less to simply version bump the pex requirement and test it out end to end.

I can help you get the change shipped in pex and released to pypi for consumption. Feel free to submit a PR and continue the discussion on https://github.com/pantsbuild/pex/issues/93.

[ghost]

@kwlzn Sorry for the dilatory response - If no one's been working on this as yet, I'd love to hop in next week when I'm on vacation and see what I can come up with. Please let me know if this is something that's up for grabs. Thanks!

[kwlzn]

@copyconstructor definitely up for grabs - feel free.

[tispratik]

Just checking if this is in the works?

[skhalymon]

@tispratik no, it isn't

[stuhood]

This is resolved as of pants 1.26.x via pex 2!

[jsirois]

Not so fast, still some work to do on the Pants side:
https://github.com/pantsbuild/pants/blob/acde9be3845dc5af39d14e9a5188a84742d215d3/src/python/pants/python/python_requirement.py#L8-L33

pkg_resources doesn't understand anything except traditional requirement strings and line 33 will blow up.

[darthveda-ai]

Having support for URL to wheel files in third party dependency would be very helpful. Lack of this support currently, has become a blocker for adoption of pants across the repo in my usecase. A gentle bump from my end to increase its priority.