Panel: Startup Variables Ignored By Wings

Created on 24 Aug 2020 · 10Comments · Source: pterodactyl/panel

Background (please complete the following information):

Panel or Daemon: Both
Version of Panel/Daemon: 1.0.0-rc1
Server's OS: Ubuntu 18.04
Your Computer's OS & Browser: Win10/Firefox

Describe the bug
It seems that any startup variables changed at server creation OR post-creation are ignored by wings, but are updated to the database. On top of this, the UI does not update the "startup command" string when variables are changed/saved.

Example: https://gyazo.com/f1953f67d0c59608b63f15130a7694ba

To Reproduce

Create A Server / Select Existing Server
Change Startup Command Variables
Start/Restart Server
See No Changes Executed

Expected behavior
Startup variables to take effect. Wings seems to only use the default nest variables.

bug

Source

Zendrex

Most helpful comment

It seems all variables aren't parsed (same for installation variables). When I running installation script, default variables are used instead of server variables.

Corenb on 24 Aug 2020

👍2

All 10 comments

Does restarting wings pull new variables?

AreYouRlyScared on 24 Aug 2020

@Sir3lit I've attempted this before, and did again just now with no avail.

Zendrex on 24 Aug 2020

It seems all variables aren't parsed (same for installation variables). When I running installation script, default variables are used instead of server variables.

Corenb on 24 Aug 2020

👍2

It is quite possible I broke this unintentionally when I made changes to startup variable handling. I'm guessing the API is actually sending along incorrect values. You can confirm this by checking the server install logs in /var/log/pterodactyl I believe.

DaneEveritt on 24 Aug 2020

That does seem to be the issue. That it's passing the defaults to the install script.

AreYouRlyScared on 25 Aug 2020

Duplicate of #2261 (which has been resolved due to a pull request)

matthewpi on 25 Aug 2020

😕1

This isn't a duplicate.

DaneEveritt on 25 Aug 2020

@DaneEveritt
Just tested RC2, however it seems that this issue still persists in some manner. Restarting wings does grab the correct variables, however updating them post-restart still doesn't update wings.

Zendrex on 26 Aug 2020

Also have learned that variables are still not updated in the log, however they seem to work within wings.
https://gyazo.com/b902806d6d6ab2891fcd33e3523817f9 (parkervcp discordjs egg)

Zendrex on 26 Aug 2020

Also have learned that variables are still not updated in the log, however they seem to work within wings.
https://gyazo.com/b902806d6d6ab2891fcd33e3523817f9 (parkervcp discordjs egg)

This is specific to how I am parsing the commands. I'm not going to sped a ton of time working on fixing that wither.