Pagedown: Page numbers disappeared from page reference

Created on 10 Jul 2019  路  8Comments  路  Source: rstudio/pagedown

As far as I checked by rendering inst/examples/index.Rmd, the page numbers disappeared since 216c09a9435788b0b4f2b993828ca91b8a3156d8.

Below is a screenshot of current https://pagedown.rbind.io/#page-references

image

bug

Most helpful comment

@RLesur FYI, pagedown v0.3 is on CRAN now.

All 8 comments

@RLesur After this issue is resolved, I'd like to upload a new version of pagedown to CRAN because it has been almost half a year since the last update. No hurry, though.

@yihui We are sync. I precisely wanted to inspect this issue today before going on holidays.

@atusy Thanks a lot for having spotted the exact commit. This was super helpful!
The problem comes more precisely from https://github.com/rstudio/pagedown/commit/216c09a9435788b0b4f2b993828ca91b8a3156d8#diff-b2e946e796db5bbbe9e9b33dd905e4b7L184
I don't know why I've removed this <div>. Sorry for that!

There's another problem to fix: with Pandoc 2.7.3, <a></a> elements are present in code blocks. Therefore, the CSS introduces pages reference in code blocks like that:

pandoc273

Thank you, too!!
I locally checked it works now :smile:

@RLesur Perfect! Please let me know whenever you feel you are ready for the next release, and I'll upload it to CRAN. We certainly don't have to address all issues. I think we have had enough items in NEWS.md that can warrant a CRAN update.

@yihui I will leave tomorrow and won't be able to contribute to open source projects for three weeks.
I think you can release 0.3 when you want.

Sounds good. Thank you!

@RLesur FYI, pagedown v0.3 is on CRAN now.

Was this page helpful?
0 / 5 - 0 ratings